Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Geo_point should be excluded from terms aggregation #109210

Merged
merged 6 commits into from
Aug 30, 2021
Merged

[TSVB] Geo_point should be excluded from terms aggregation #109210

merged 6 commits into from
Aug 30, 2021

Conversation

VladLasitsa
Copy link
Contributor

Closes: #103472

Summary

Adds field type restrictions for terms aggregation like in data plugin because terms aggregation supports only number, date, string, ip and boolean field types.

@VladLasitsa VladLasitsa requested a review from alexwizp August 19, 2021 09:20
@VladLasitsa VladLasitsa self-assigned this Aug 19, 2021
@VladLasitsa VladLasitsa added Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0 labels Aug 19, 2021
alexwizp
alexwizp approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally

@VladLasitsa VladLasitsa marked this pull request as ready for review August 20, 2021 10:42
@VladLasitsa VladLasitsa requested a review from a team August 20, 2021 10:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@VladLasitsa VladLasitsa requested a review from stratoula August 20, 2021 10:42
@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor

stratoula commented Aug 30, 2021 •
edited
Loading

@VladLasitsa this works fine for the terms aggregation in timeseries, but the issue also mentions the table. We should also apply these restrictions there too in order to close this issue.

image

@VladLasitsa
Copy link
Contributor Author

@VladLasitsa this works fine for the terms aggregation in timeseries, but the issue also mentions the table. We should also apply these restrictions there too in order to close this issue.

image

Added restrictions.

stratoula
stratoula approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx @VladLasitsa, now it works like a charm! Code LGTM, tested it locally in Chrome.

@VladLasitsa VladLasitsa added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 30, 2021
@VladLasitsa VladLasitsa enabled auto-merge (squash) August 30, 2021 15:40
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1003.8KB 1004.1KB +372.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

@VladLasitsa VladLasitsa merged commit f7db559 into elastic:master Aug 30, 2021
@kibanamachine kibanamachine mentioned this pull request Aug 30, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 30, 2021
@VladLasitsa @kibanamachine
[TSVB] Geo_point should be excluded from terms aggregation (elastic#1…
21425bf 
…09210)

* Add field type restriction for terms agg

* Fix test

* Add restriction for 'group by' in table

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 30, 2021
@kibanamachine @VladLasitsa
[TSVB] Geo_point should be excluded from terms aggregation (#109210) (#…
5e28699 
…110501)

* Add field type restriction for terms agg

* Fix test

* Add restriction for 'group by' in table

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Uladzislau Lasitsa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@alexwizp alexwizp alexwizp approved these changes

Assignees

@VladLasitsa VladLasitsa

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TSVB] Geo_point should be excluded from terms aggregation
5 participants
@VladLasitsa @elasticmachine @stratoula @kibanamachine @alexwizp