Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): moving @kbn/mapbox-gl to babel transpiler #109082

Merged
merged 3 commits into from
Aug 18, 2021
Merged

chore(NA): moving @kbn/mapbox-gl to babel transpiler #109082

merged 3 commits into from
Aug 18, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Aug 18, 2021

One step forward on #69706

That PR moves the @kbn/mapbox-gl from using tsc compiler to babel transpiler to produce the js outputs.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.14.1 labels Aug 18, 2021
@mistic mistic requested a review from jbudz August 18, 2021 11:58
@mistic mistic requested a review from a team as a code owner August 18, 2021 11:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic
Copy link
Member Author

mistic commented Aug 18, 2021

@elasticmachine merge upstream

@thomasneirynck thomasneirynck self-requested a review August 18, 2021 13:55
thomasneirynck
thomasneirynck reviewed Aug 18, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @mistic , given that this will be backported to 7.14, this might block #104505

Just want to make sure we're not stepping over each other on this one.

packages/kbn-mapbox-gl/src/index.ts Outdated Show resolved Hide resolved
@thomasneirynck thomasneirynck mentioned this pull request Aug 18, 2021
Merged
@mistic mistic enabled auto-merge (squash) August 18, 2021 14:06
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 3.2MB 3.2MB +63.0B
visTypeVega 2.5MB 2.5MB +51.0B
total +114.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 66.0KB 65.9KB -65.0B
visTypeVega 55.4KB 55.3KB -65.0B
total -130.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic added v7.16.0 and removed v7.15.0 labels Aug 18, 2021
jbudz
jbudz reviewed Aug 18, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasneirynck thomasneirynck self-requested a review August 18, 2021 19:51
thomasneirynck
thomasneirynck reviewed Aug 18, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! tested in chrome, both Maps and Vega plugins.

@thomasneirynck thomasneirynck self-requested a review August 18, 2021 19:51
@mistic mistic merged commit 51c1594 into elastic:master Aug 18, 2021
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v7.15.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 18, 2021
@mistic @kibanamachine
chore(NA): moving @kbn/mapbox-gl to babel transpiler (elastic#109082)
a610a12 
* chore(NA): moving @kbn/mapbox-gl to babel transpiler

* chore(NA): structure exports

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Aug 18, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 18, 2021
@mistic @kibanamachine
chore(NA): moving @kbn/mapbox-gl to babel transpiler (elastic#109082)
07d5e7c 
* chore(NA): moving @kbn/mapbox-gl to babel transpiler

* chore(NA): structure exports

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Aug 18, 2021
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
✅ 7.15
✅ 7.x
❌ 7.14 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 109082

kibanamachine added a commit that referenced this pull request Aug 18, 2021
@kibanamachine @mistic
chore(NA): moving @kbn/mapbox-gl to babel transpiler (#109082) (#109164)
8f910f4 
* chore(NA): moving @kbn/mapbox-gl to babel transpiler

* chore(NA): structure exports

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Tiago Costa <[email protected]>
kibanamachine added a commit that referenced this pull request Aug 18, 2021
@kibanamachine @mistic
chore(NA): moving @kbn/mapbox-gl to babel transpiler (#109082) (#109163)
d791226 
* chore(NA): moving @kbn/mapbox-gl to babel transpiler

* chore(NA): structure exports

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Tiago Costa <[email protected]>
mistic added a commit to mistic/kibana that referenced this pull request Aug 19, 2021
@mistic
chore(NA): moving @kbn/mapbox-gl to babel transpiler (elastic#109082)
292efad 
* chore(NA): moving @kbn/mapbox-gl to babel transpiler

* chore(NA): structure exports

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	packages/kbn-mapbox-gl/BUILD.bazel
#	packages/kbn-mapbox-gl/tsconfig.json
@mistic mistic mentioned this pull request Aug 19, 2021
Merged
mistic added a commit that referenced this pull request Aug 19, 2021
@mistic
chore(NA): moving @kbn/mapbox-gl to babel transpiler (#109082) (#109228)
cae6a8a 
* chore(NA): moving @kbn/mapbox-gl to babel transpiler

* chore(NA): structure exports

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	packages/kbn-mapbox-gl/BUILD.bazel
#	packages/kbn-mapbox-gl/tsconfig.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz left review comments

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.1 v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mistic @elasticmachine @kibanamachine @thomasneirynck @jbudz