[Security solution] [Endpoint] Remove linked policy from trusted apps when removing endpoint integration #108347

dasansol92 · 2021-08-12T10:35:50Z

Summary

Adds a delete callback for policies that retrieves all trusted apps with that policy assigned and remove it from those.
It also works when removing the whole policy (not just the endpoint integration)
This needs trustedAppsByPolicyEnabled feature flag enabled

…should_no_longer_reference_the_policy_when_removed-767

…abled

…should_no_longer_reference_the_policy_when_removed-767

dasansol92 · 2021-08-12T14:23:56Z

@elasticmachine merge upstream

…should_no_longer_reference_the_policy_when_removed-767

elasticmachine · 2021-08-13T09:24:46Z

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

x-pack/plugins/security_solution/server/fleet_integration/fleet_integration.test.ts

elasticmachine · 2021-08-13T09:26:25Z

Pinging @elastic/fleet (Team:Fleet)

…e checked during TA update

…issue with Without method from lodash

…policy_specific_trusted_apps_should_no_longer_reference_the_policy_when_removed-767

x-pack/plugins/fleet/server/services/package_policy.ts

…s an error

…llbacks()` is called

…policy_specific_trusted_apps_should_no_longer_reference_the_policy_when_removed-767

elasticmachine · 2021-08-18T18:30:49Z

Pinging @elastic/apm-ui (Team:apm)

kibanamachine · 2021-08-18T20:52:10Z

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

API count

id	before	after	diff
`fleet`	1168	1166	-2

API count missing comments

id	before	after	diff
`fleet`	1067	1065	-2

History

💔 Build #146688 failed 88bd73a
💔 Build #146593 failed d76e230
💚 Build #145236 succeeded 8161e4c
💚 Build #145164 succeeded aca93ba
💚 Build #145141 succeeded 2b0efcf

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

ashokaditya

🚀 Just have a question.

x-pack/plugins/fleet/server/types/extensions.ts

nchaulet

Fleet changes 🚀

smith

APM changes look good

… when removing endpoint integration (elastic#108347) * Remove policy from trusted app when this is removed from fleet * Fleet: run package delete external callbacks when the Agent Policy is deleted

kibanamachine · 2021-08-19T17:49:04Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

… when removing endpoint integration (#108347) (#109296) * Remove policy from trusted app when this is removed from fleet * Fleet: run package delete external callbacks when the Agent Policy is deleted Co-authored-by: David Sánchez <[email protected]>

dasansol92 · 2021-09-01T09:07:08Z

x-pack/plugins/fleet/server/services/package_policy.ts

+    const errorsThrown: Error[] = [];
+
+    if (externalCallbacks && externalCallbacks.size > 0) {
+      for (const callback of externalCallbacks) {


dasansol92 added 7 commits August 3, 2021 12:10

Remove policy from trusted app when this is removed from fleet

b8550b0

Merge branch 'master' into feat/olm-any_policy_specific_trusted_apps_…

d7a3d91

…should_no_longer_reference_the_policy_when_removed-767

Use exceptionsList client instead of saveObject client

6ab3659

Merge branch 'master' into feat/olm-any_policy_specific_trusted_apps_…

745c43e

…should_no_longer_reference_the_policy_when_removed-767

Merge branch 'master' into feat/olm-any_policy_specific_trusted_apps_…

40e16ee

…should_no_longer_reference_the_policy_when_removed-767

Skip actions when FF is not enabled

7be7809

Adds missing file on last commit - skip remove action if FF is not en…

561fe39

…abled

dasansol92 added release_note:enhancement v8.0.0 Team:Defend Workflows “EDR Workflows” sub-team of Security Solution auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Aug 12, 2021

dasansol92 added 2 commits August 12, 2021 12:50

Merge branch 'master' into feat/olm-any_policy_specific_trusted_apps_…

97bcda9

…should_no_longer_reference_the_policy_when_removed-767

Tries to add a unit test, needs to be completed/fixed

06c62d8

kibanamachine and others added 3 commits August 12, 2021 10:23

Merge branch 'master' into feat/olm-any_policy_specific_trusted_apps_…

5e7b936

…should_no_longer_reference_the_policy_when_removed-767

Merge branch 'master' into feat/olm-any_policy_specific_trusted_apps_…

74e89b4

…should_no_longer_reference_the_policy_when_removed-767

Fixes type check error

b0ba9c8

dasansol92 marked this pull request as ready for review August 13, 2021 09:24

dasansol92 requested review from a team as code owners August 13, 2021 09:24

dasansol92 requested review from ashokaditya and paul-tavares August 13, 2021 09:24

dasansol92 commented Aug 13, 2021

View reviewed changes

x-pack/plugins/security_solution/server/fleet_integration/fleet_integration.test.ts Outdated Show resolved Hide resolved

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 13, 2021

dasansol92 added 2 commits August 13, 2021 12:26

Fixes some errors and adds a unit test. There is a casting needs to b…

2b0efcf

…e checked during TA update

Unlink policy from TA when removing the entire policy. Also fixes an …

aca93ba

…issue with Without method from lodash

paul-tavares added 2 commits August 18, 2021 08:50

Fix mock

faa0e24

Merge remote-tracking branch 'upstream/master' into pr/david/olm-any_…

d76e230

…policy_specific_trusted_apps_should_no_longer_reference_the_policy_when_removed-767

paul-tavares reviewed Aug 18, 2021

View reviewed changes

x-pack/plugins/fleet/server/services/package_policy.ts Outdated Show resolved Hide resolved

paul-tavares added 6 commits August 18, 2021 09:13

Allow all delete external callbacks to be executed even if one return…

36bb904

…s an error

Fix fleet integration tests

73c9a00

AgentPolicy delete tests to ensure `packagePolicy.runDeleteExternalCa…

4afb3e5

…llbacks()` is called

tests for PackagePolicyService.runDeleteExternalCallbacks()

9f487ff

code review feedback

49bf709

Merge remote-tracking branch 'upstream/master' into pr/david/olm-any_…

88bd73a

…policy_specific_trusted_apps_should_no_longer_reference_the_policy_when_removed-767

paul-tavares requested review from nchaulet, ashokaditya and paul-tavares August 18, 2021 16:28

paul-tavares self-assigned this Aug 18, 2021

mistic added v7.16.0 and removed v7.15.0 labels Aug 18, 2021

Fix types in APM registerFleetPolicyCallbacks()

e9b4fb4

dasansol92 requested a review from a team as a code owner August 18, 2021 18:30

botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Aug 18, 2021

paul-tavares approved these changes Aug 18, 2021

View reviewed changes

ashokaditya approved these changes Aug 19, 2021

View reviewed changes

x-pack/plugins/fleet/server/types/extensions.ts Show resolved Hide resolved

nchaulet approved these changes Aug 19, 2021

View reviewed changes

smith approved these changes Aug 19, 2021

View reviewed changes

paul-tavares merged commit 79e63cc into elastic:master Aug 19, 2021

kibanamachine mentioned this pull request Aug 19, 2021

[7.x] [Security solution] [Endpoint] Remove linked policy from trusted apps when removing endpoint integration (#108347) #109296

Merged

dasansol92 commented Sep 1, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security solution] [Endpoint] Remove linked policy from trusted apps when removing endpoint integration #108347

[Security solution] [Endpoint] Remove linked policy from trusted apps when removing endpoint integration #108347

dasansol92 commented Aug 12, 2021 •

edited

Loading

dasansol92 commented Aug 12, 2021

elasticmachine commented Aug 13, 2021

elasticmachine commented Aug 13, 2021

elasticmachine commented Aug 18, 2021

kibanamachine commented Aug 18, 2021

API count

API count missing comments

ashokaditya left a comment

nchaulet left a comment

smith left a comment

kibanamachine commented Aug 19, 2021

dasansol92 Sep 1, 2021

[Security solution] [Endpoint] Remove linked policy from trusted apps when removing endpoint integration #108347

[Security solution] [Endpoint] Remove linked policy from trusted apps when removing endpoint integration #108347

Conversation

dasansol92 commented Aug 12, 2021 • edited Loading

Summary

dasansol92 commented Aug 12, 2021

elasticmachine commented Aug 13, 2021

elasticmachine commented Aug 13, 2021

elasticmachine commented Aug 18, 2021

kibanamachine commented Aug 18, 2021

💚 Build Succeeded

Metrics [docs]

API count

API count missing comments

History

ashokaditya left a comment

Choose a reason for hiding this comment

nchaulet left a comment

Choose a reason for hiding this comment

smith left a comment

Choose a reason for hiding this comment

kibanamachine commented Aug 19, 2021

💚 Backport successful

dasansol92 Sep 1, 2021

Choose a reason for hiding this comment

dasansol92 commented Aug 12, 2021 •

edited

Loading