New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Displays callout when transaction events are used instead of aggregrated metrics #108080

Merged

ogupte merged 7 commits into elastic:master from ogupte:apm-107477-callout-transaction-metrics-fallback

Aug 11, 2021

Contributor

ogupte commented Aug 10, 2021 •

edited

Loading

Closes #107477


          [APM] Displays callout when transaction events are used instead of ag…

896417d

…gregrated metrics (elastic#107477)

ogupte added release_note:enhancement v7.15.0 labels

sorenlouv reviewed

View reviewed changes

x-pack/plugins/apm/public/components/app/service_inventory/index.tsx Show resolved Hide resolved

sorenlouv reviewed

View reviewed changes

x-pack/plugins/apm/public/hooks/use_search_aggregated_transactions_fetcher.tsx Outdated Show resolved Hide resolved

sorenlouv reviewed

View reviewed changes

x-pack/plugins/apm/server/routes/search_aggregated_transactions.ts Outdated Show resolved Hide resolved

sorenlouv reviewed

View reviewed changes

x-pack/plugins/apm/public/components/shared/aggregated_transactions_callout/index.tsx Outdated Show resolved Hide resolved


          Apply suggestions from code review

9c6de97

Co-authored-by: Søren Louv-Jansen <[email protected]>

formgeist reviewed

View reviewed changes

Contributor

formgeist left a comment

Just a suggestion to reduce the callout size

x-pack/plugins/apm/public/components/shared/aggregated_transactions_callout/index.tsx Show resolved Hide resolved


          PR feedback, and isolates the logic for getting the fallback strategy

5361c30

sorenlouv reviewed

View reviewed changes

x-pack/plugins/apm/server/routes/fallback_to_transactions.ts Outdated Show resolved Hide resolved

sorenlouv approved these changes

View reviewed changes


          PR feedback

b0169f8

ogupte added the auto-backport label

ogupte marked this pull request as ready for review

August 10, 2021 23:51

ogupte requested a review from a team as a code owner

August 10, 2021 23:51

ogupte enabled auto-merge (squash)

August 10, 2021 23:51

Contributor Author

ogupte commented Aug 10, 2021

@elasticmachine merge upstream


          Merge branch 'master' into apm-107477-callout-transaction-metrics-fal…

de41e53

…lback

botelastic bot added the Team:APM - DEPRECATED label

Contributor

elasticmachine commented Aug 10, 2021

Pinging @elastic/apm-ui (Team:apm)


          fixes broken tests

bc581ce

sorenlouv reviewed

View reviewed changes

x-pack/plugins/apm/server/lib/helpers/aggregated_transactions/get_fallback_to_transactions.ts Show resolved Hide resolved

sorenlouv reviewed

View reviewed changes

x-pack/plugins/apm/server/lib/helpers/aggregated_transactions/get_fallback_to_transactions.ts Outdated Show resolved Hide resolved

formgeist reviewed

View reviewed changes

Contributor

formgeist left a comment

Another suggestion to replace the title contents with the description thereby reducing the callout size.

x-pack/plugins/apm/public/components/shared/aggregated_transactions_callout/index.tsx Outdated Show resolved Hide resolved

Contributor

formgeist commented Aug 11, 2021

@ogupte @sqren Quick question: shouldn't I get the callout when I'm e.g. querying for processor.event="transaction"?


          fixes API test snapshot, decrease callout size, code changes

c5e2579

Contributor Author

ogupte commented Aug 11, 2021 •

edited

Loading

@ogupte @sqren Quick question: shouldn't I get the callout when I'm e.g. querying for processor.event="transaction"?

@formgeist seems to be working when i query for it:

Contributor

kibanamachine commented Aug 11, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1584	1586	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	4.3MB	4.3MB	+2.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ogupte merged commit ae73cf8 into elastic:master

kibanamachine mentioned this pull request

[7.x] [APM] Displays callout when transaction events are used instead of aggregrated metrics (#108080) #108232

Merged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request


          [APM] Displays callout when transaction events are used instead of ag…

d1ba7f3

…gregrated metrics (elastic#108080)

* [APM] Displays callout when transaction events are used instead of aggregrated metrics (elastic#107477)

* Apply suggestions from code review

Co-authored-by: Søren Louv-Jansen <[email protected]>

* PR feedback, and isolates the logic for getting the fallback strategy

* PR feedback

Co-authored-by: Søren Louv-Jansen <[email protected]>

Contributor

kibanamachine commented Aug 11, 2021

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request


          [APM] Displays callout when transaction events are used instead of ag…

8cebd4a

…gregrated metrics (#108080) (#108232)

* [APM] Displays callout when transaction events are used instead of aggregrated metrics (#107477)

* Apply suggestions from code review

Co-authored-by: Søren Louv-Jansen <[email protected]>

* PR feedback, and isolates the logic for getting the fallback strategy

* PR feedback

Co-authored-by: Søren Louv-Jansen <[email protected]>

Co-authored-by: Oliver Gupte <[email protected]>
Co-authored-by: Søren Louv-Jansen <[email protected]>

formgeist mentioned this pull request

[APM] Update the callout messaging around switching to transaction events based data #108830

Closed

3 tasks

ogupte mentioned this pull request

[APM] Replaces the transaction events fallback callout with an info badge #108925

Merged

cauemarcondes mentioned this pull request

Fix 7.15 release notes #112411

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport release_note:enhancement Team:APM - DEPRECATED v7.15.0