Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Add new ftr_e2e to kibana CI and remove current e2e tests. #107593

Merged
merged 18 commits into from
Aug 11, 2021
Merged

[APM] Add new ftr_e2e to kibana CI and remove current e2e tests. #107593

merged 18 commits into from
Aug 11, 2021

Conversation

cauemarcondes
Copy link
Contributor

closes #107578

@cauemarcondes cauemarcondes marked this pull request as ready for review August 9, 2021 22:20
@cauemarcondes cauemarcondes requested review from a team as code owners August 9, 2021 22:20
@cauemarcondes cauemarcondes added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.15.0 labels Aug 9, 2021
@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream`

@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Aug 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes changed the title [WIP][APM] Add new ftr_e2e to kibana CI and remove current e2e tests. [APM] Add new ftr_e2e to kibana CI and remove current e2e tests. Aug 9, 2021
sorenlouv
sorenlouv approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Mostly nits for refactoring the security script

@cauemarcondes cauemarcondes requested a review from a team as a code owner August 10, 2021 19:01
brianseeders
brianseeders approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@brianseeders brianseeders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipeline changes look good

dominiqueclarke
dominiqueclarke reviewed Aug 10, 2021
View reviewed changes
x-pack/plugins/apm/e2e/cypress/integration/csm_dashboard.feature
@@ -30,11 +25,6 @@ Feature: CSM Dashboard
Then should display percentile for page load chart
And should display tooltip on hover

Scenario: Breakdown filter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to comment these out instead with a comment stating they are flaky so that the Uptime team can later review? I am unfamiliar with the .feature file type, so I genuinely don't know.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me neither 😅, that's why I deleted it. But it could be restored on GitHub anyway history.

@cauemarcondes cauemarcondes enabled auto-merge (squash) August 11, 2021 02:24
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +42.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 6ed4b4f into elastic:master Aug 11, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 11, 2021
@cauemarcondes @kibanamachine
[APM] Add new ftr_e2e to kibana CI and remove current e2e tests. (ela…
f42eb6b 
…stic#107593)
@kibanamachine kibanamachine mentioned this pull request Aug 11, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

spalger added a commit that referenced this pull request Aug 11, 2021
@spalger
fix newly introduced type error (#107593)
65a5cb1
spalger added a commit to kibanamachine/kibana that referenced this pull request Aug 11, 2021
@spalger
fix newly introduced type error (elastic#107593)
5ac03d9 
(cherry picked from commit 65a5cb1)
kibanamachine added a commit that referenced this pull request Aug 11, 2021
@kibanamachine @cauemarcondes @spalger
[7.x] [APM] Add new ftr_e2e to kibana CI and remove current e2e tests. (
a4ee786 
#107593) (#108138)

* [APM] Add new ftr_e2e to kibana CI and remove current e2e tests. (#107593)

* fix newly introduced type error (#107593)

(cherry picked from commit 65a5cb1)

Co-authored-by: Cauê Marcondes <[email protected]>
Co-authored-by: spalger <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 11, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/new…
66273c7 
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (101 commits)
  [ML] APM Latency Correlations: Field/value candidates prioritization (elastic#107370)
  [Reporting] Add lenience to a test on the order of asserted logs (elastic#108135)
  [Lens] fix do not submit invalid query in filtered metric (elastic#107542)
  skip flaky test (elastic#108043)
  fix newly introduced type error (elastic#107593)
  [Reporting] server side code clean up (elastic#106940)
  [build_ts_refs] improve caches, allow building a subset of projects (elastic#107981)
  [APM] Add new ftr_e2e to kibana CI and remove current e2e tests. (elastic#107593)
  add manage rules link to alerts dropdown (elastic#107950)
  [ML] Enable Index data visualizer document count chart to update time range query (elastic#106438)
  [Security Solutions][Detection Engine] Fixes "undefined" crash for author field by adding a migration for it (elastic#107230)
  [Actions UI] Fixed Jira Api token label. (elastic#107776)
  [Alerting UI] Fixed display permissions for edit/delete buttons when user has read only access. (elastic#107996)
  [Maps] fix code owners (elastic#108106)
  Update EMS landing page url (elastic#108102)
  Do not render page header for loading domains (elastic#108078)
  Update dependency @elastic/charts to v33.2.2 (elastic#107939)
  [APM] Display throughput as tps (instead of tpm) when bucket size < 60 seconds (elastic#107850)
  [Fleet] Fix all category count (elastic#108089)
  [Security Solution][Bug] - Disable alert table RBAC until fields sorted (elastic#108034)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/export_types/common/generate_png.ts
#	x-pack/plugins/reporting/server/lib/screenshots/index.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable.test.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable.ts
smith
smith reviewed Aug 16, 2021
View reviewed changes
x-pack/plugins/apm/ftr_e2e/cypress/integration/read_only_user/deep_links.spec.ts
@@ -5,7 +5,7 @@
* 2.0.
*/

describe('APM depp links', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-233829319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith left review comments

@tylersmalley tylersmalley tylersmalley approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

@brianseeders brianseeders brianseeders approved these changes

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Add new ftr_e2e to kibana CI and remove current e2e tests.
8 participants
@cauemarcondes @elasticmachine @kibanamachine @smith @tylersmalley @sorenlouv @brianseeders @dominiqueclarke