Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to vis types part 1 #107535

Merged
merged 12 commits into from
Aug 20, 2021
Merged

Move to vis types part 1 #107535

merged 12 commits into from
Aug 20, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Aug 3, 2021 •
edited
Loading

Part of #107500

This is the first part of moving all the vis_type_* plugins to a new folder vis_types.

In this PR three plugins are moved:

  • vislib
  • XY
  • pie

Changes in details are:

  • Moved the vis_type_xy, vis_type_pie and vis_type__vislib to a new folder vis_types (just a folder)
  • Remove the vis_type_ from the folder name. From now on they will be xy, pie, vislib. Important note: Only the folder names have changed and not the plugin ids.
  • All the relative paths have been updated
  • Updated all the kibana conf files (jest, tsconfig) to take under consideration the new paths

@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v7.15.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 10, 2021
@stratoula stratoula marked this pull request as ready for review August 10, 2021 06:09
@stratoula stratoula requested a review from a team August 10, 2021 06:09
@stratoula stratoula requested review from a team as code owners August 10, 2021 06:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

peteharverson
peteharverson approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML edit LGTM

ryankeairns
ryankeairns approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving SCSS file moves.

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Aug 18, 2021
@stratoula stratoula added v7.16.0 and removed v7.15.0 labels Aug 18, 2021
@mbondyra
Copy link
Contributor

mbondyra commented Aug 19, 2021 •
edited
Loading

Code LGTM, I tested by clicking from the vis to vis and see if it loads properly. Didn't observe any problems (and in this case they should be caught by functional tests)

mistic
mistic approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes on files under operations team code owners LGTM

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula stratoula added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 20, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeVislib 32.7KB 32.6KB -27.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit cb86892 into elastic:master Aug 20, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 107535

stratoula added a commit to stratoula/kibana that referenced this pull request Aug 20, 2021
@stratoula
Move to vis types part 1 (elastic#107535)
82ffabd 
* Move to vis types part 1

* Fix types

* fix more types

* Fix paths

* Update readme file

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	.github/CODEOWNERS
@stratoula stratoula mentioned this pull request Aug 20, 2021
Merged
stratoula added a commit that referenced this pull request Aug 20, 2021
@stratoula
Move to vis types part 1 (#107535) (#109393)
a7289d1 
* Move to vis types part 1

* Fix types

* fix more types

* Fix paths

* Update readme file

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	.github/CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@mbondyra mbondyra mbondyra approved these changes

@mistic mistic mistic approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@stratoula @elasticmachine @mbondyra @kibanamachine @ryankeairns @mistic @peteharverson