chore(NA): moving @kbn/ace to babel transpiler #106922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-datemath-with-babel
mistic
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Jul 27, 2021
…ker/x_json.ace.worker.js
|
@elasticmachine merge upstream |
yuliacech
approved these changes
Jul 28, 2021
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 28, 2021
* chore(NA): first custom rules for jsts_transpiler * chore(NA): update jsts_transpiler macro * chore(NA): moving @elastic/datemath to babel transpiler * chore(NA): change gitignore rules for bazel * chore(NA): moving @kbn/ace to babel transpiler * chore(NA): remove deps from js_library * chore(NA): added runtime deps * chore(NA): do not transpile packages/kbn-ace/src/ace/modes/x_json/worker/x_json.ace.worker.js Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 28, 2021
* chore(NA): first custom rules for jsts_transpiler * chore(NA): update jsts_transpiler macro * chore(NA): moving @elastic/datemath to babel transpiler * chore(NA): change gitignore rules for bazel * chore(NA): moving @kbn/ace to babel transpiler * chore(NA): remove deps from js_library * chore(NA): added runtime deps * chore(NA): do not transpile packages/kbn-ace/src/ace/modes/x_json/worker/x_json.ace.worker.js Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 28, 2021
* chore(NA): first custom rules for jsts_transpiler * chore(NA): update jsts_transpiler macro * chore(NA): moving @elastic/datemath to babel transpiler * chore(NA): change gitignore rules for bazel * chore(NA): moving @kbn/ace to babel transpiler * chore(NA): remove deps from js_library * chore(NA): added runtime deps * chore(NA): do not transpile packages/kbn-ace/src/ace/modes/x_json/worker/x_json.ace.worker.js Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Tiago Costa <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 28, 2021
* chore(NA): first custom rules for jsts_transpiler * chore(NA): update jsts_transpiler macro * chore(NA): moving @elastic/datemath to babel transpiler * chore(NA): change gitignore rules for bazel * chore(NA): moving @kbn/ace to babel transpiler * chore(NA): remove deps from js_library * chore(NA): added runtime deps * chore(NA): do not transpile packages/kbn-ace/src/ace/modes/x_json/worker/x_json.ace.worker.js Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Tiago Costa <[email protected]>
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
* chore(NA): first custom rules for jsts_transpiler * chore(NA): update jsts_transpiler macro * chore(NA): moving @elastic/datemath to babel transpiler * chore(NA): change gitignore rules for bazel * chore(NA): moving @kbn/ace to babel transpiler * chore(NA): remove deps from js_library * chore(NA): added runtime deps * chore(NA): do not transpile packages/kbn-ace/src/ace/modes/x_json/worker/x_json.ace.worker.js Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step forward on #69706
That PR moves the @kbn/ace from using tsc compiler to babel transpiler to produce the js outputs.