Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Pass EuiIcon props to connectors logos #106449

Merged
merged 2 commits into from
Jul 22, 2021
Merged

[Alerting] Pass EuiIcon props to connectors logos #106449

merged 2 commits into from
Jul 22, 2021

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Jul 21, 2021 •
edited
Loading

Summary

PR #97770 changed the way connectors' SVG logos is being imported. This caused the logos in the connectors dropdown on the cases configuration page to be bigger than it was before. The reason is that the EuiProps are not being passed down to the SVG icon. This PR fixes this issue.

Fixes: #100763

Checklist

Delete any items that are not applicable to this PR.

  • This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

For maintainers

@cnasikas cnasikas added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.14.0 v7.15.0 labels Jul 21, 2021
@cnasikas cnasikas requested a review from YulNaumenko July 21, 2021 17:58
@cnasikas cnasikas self-assigned this Jul 21, 2021
@cnasikas cnasikas requested a review from a team as a code owner July 21, 2021 17:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

YulNaumenko
YulNaumenko approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.6MB +1.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas cnasikas merged commit e383b57 into elastic:master Jul 22, 2021
@cnasikas cnasikas deleted the fix_icons branch July 22, 2021 08:15
This was referenced Jul 22, 2021
Merged
Merged
cnasikas added a commit to cnasikas/kibana that referenced this pull request Jul 22, 2021
@cnasikas @kibanamachine
[Alerting] Pass EuiIcon props to connectors logos (elastic#106449)
ad72007 
Co-authored-by: Kibana Machine <[email protected]>
cnasikas added a commit that referenced this pull request Jul 22, 2021
@cnasikas @kibanamachine
[Alerting] Pass EuiIcon props to connectors logos (#106449) (#106500)
834521c 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
cnasikas added a commit that referenced this pull request Jul 22, 2021
@cnasikas @kibanamachine
[Alerting] Pass EuiIcon props to connectors logos (#106449) (#106499)
c2b9ff4 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees

@cnasikas cnasikas

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cases] Fix connector's logo sizes on cases
4 participants
@cnasikas @elasticmachine @kibanamachine @YulNaumenko