[RAC] [Metrics UI] Register Inventory rule types with new RAC rules registry #105706

mgiota · 2021-07-15T06:41:21Z

This PR Fixes #105746. It
registers Inventory rule type with new RAC rules registry. Alerts created from these registered rules show up in the observability alerting table.

Relates to:
#98360
#105785

Review notes

The value of the reason column is temporary Current value is X (threshold of Y) and should be fixed as part of another ticket. Similarly to the log threshold implementation the params need to be serialized into an inventory-threshold-rule-namespaced field in the doc.
Type checking is currently missing and will be introduced as part of another PR
Make sure the preview executor doesn't index alerts
Temporarily the reason will display a simple message for the current node Inventory alert for {groupName}. Once the reason filed is indexed we will display a more descriptive message. Relates to [Logs UI] Index reason in log threshold executor #106291
The link icon at the moment opens the default inventory page. Relates to [RAC][Metrics UI] Link to an inventory item with the flyout open at a certain point in time #106497 106497

mgiota · 2021-07-20T07:21:07Z

@elasticmachine merge upstream

kibanamachine · 2021-07-20T07:21:18Z

expected head sha didn’t match current head ref.

elasticmachine · 2021-07-20T10:24:53Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

mgiota · 2021-07-20T11:23:46Z

@weltenwort I checked preview_inventory_metric_threshold_alert and it doesn't call the executor internally. So it doesn't accidentally index the produced alerts I guess. Could you double check?

weltenwort

This is definitely going into the right direction, but I left a few questions below.

x-pack/plugins/infra/common/alerting/metrics/rule_data.ts

x-pack/plugins/infra/public/alerting/inventory/rule_data_formatters.ts

.../infra/server/lib/alerting/inventory_metric_threshold/inventory_metric_threshold_executor.ts

x-pack/plugins/infra/public/alerting/inventory/rule_data_formatters.ts

…_rac_rule_registry

mgiota · 2021-07-21T13:27:47Z

@weltenwort There was a new PR merged e2aacdc#diff-f206eabccdf944b536c967e22ec43adb376f0e7322c92f5c7ee5217bda757f9fR65. I had removed the AlertType in this PR. I am now wondering if I should actually bring it back. And maybe add it to the register log threshold alert type as well?

weltenwort

I think we're almost there. Just stumbled across one typing issue which was hidden by an any.

.../infra/server/lib/alerting/inventory_metric_threshold/inventory_metric_threshold_executor.ts

… info for combined conditions

… indexed reason field

weltenwort · 2021-07-21T17:26:42Z

I think the latest CI failure was caused by the force-push. The current HEAD of the branch is still being tested, so we can just wait. ⏳

weltenwort

Well done, thanks for enduring the back-and-forth. 👏

Let's hope CI agrees 🤞 😉

kibanamachine · 2021-07-21T18:18:57Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`infra`	887	888	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`infra`	147.3KB	147.6KB	+377.0B

History

💛 Build #140096 was flaky 94955dd
💔 Build #140092 failed 193d2435184aef7bbc74a9f58fdbb715db39fadd
💚 Build #140046 succeeded 5b703c2
💔 Build #140034 failed 944c3dc
💔 Build #140016 failed 9238414

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mgiota

…egistry (elastic#105706) * WIP: register inventory metric threshold as lifecycle rule * fix inventory executor error * save alerts into ES * temp * basic format reason for inventory threshold * clean up, fix i18n error and temporarily remove types * delete serialized params * include group name in the reason * cleanup * link to default metrics page * grab the value and threshold for the inventory item * fix typo * fix check types * remove threshold and currentValue, the reason field will contain this info for combined conditions * remove thereshold and value from the reason, soon will be replaced by indexed reason field * remove unnecessary export Co-authored-by: Kibana Machine <[email protected]>

kibanamachine · 2021-07-22T09:49:15Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…egistry (#105706) (#106512) * WIP: register inventory metric threshold as lifecycle rule * fix inventory executor error * save alerts into ES * temp * basic format reason for inventory threshold * clean up, fix i18n error and temporarily remove types * delete serialized params * include group name in the reason * cleanup * link to default metrics page * grab the value and threshold for the inventory item * fix typo * fix check types * remove threshold and currentValue, the reason field will contain this info for combined conditions * remove thereshold and value from the reason, soon will be replaced by indexed reason field * remove unnecessary export Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: mgiota <[email protected]>

mgiota changed the title ~~WIP~~ [RAC] [Metrics UI] Register Metrics UI rule types with new RAC rules registry Jul 15, 2021

mgiota force-pushed the 98360_metrics_rac_rule_registry branch from 3094ccb to 7d81ac8 Compare July 15, 2021 12:18

WIP: register inventory metric threshold as lifecycle rule

9969d88

mgiota force-pushed the 98360_metrics_rac_rule_registry branch from 7d81ac8 to 9969d88 Compare July 15, 2021 21:58

mgiota added 3 commits July 16, 2021 12:52

fix inventory executor error

430b128

save alerts into ES

f719f0d

temp

6d4c1d4

mgiota force-pushed the 98360_metrics_rac_rule_registry branch from 5c30733 to b740326 Compare July 19, 2021 20:32

basic format reason for inventory threshold

43ac40e

mgiota force-pushed the 98360_metrics_rac_rule_registry branch from b740326 to 43ac40e Compare July 19, 2021 20:46

mgiota changed the title ~~[RAC] [Metrics UI] Register Metrics UI rule types with new RAC rules registry~~ [RAC] [Metrics UI] Register Inventory rule types with new RAC rules registry Jul 19, 2021

mgiota mentioned this pull request Jul 19, 2021

Register Inventory metric threshold as lifecycle rule #105746

Closed

mgiota force-pushed the 98360_metrics_rac_rule_registry branch from 1b47eea to 352736d Compare July 19, 2021 21:30

clean up, fix i18n error and temporarily remove types

c9778db

mgiota force-pushed the 98360_metrics_rac_rule_registry branch from 352736d to c9778db Compare July 19, 2021 22:00

mgiota marked this pull request as ready for review July 19, 2021 22:03

mgiota requested a review from a team as a code owner July 19, 2021 22:03

Merge branch 'master' into 98360_metrics_rac_rule_registry

1734c81

mgiota self-assigned this Jul 20, 2021

weltenwort self-requested a review July 20, 2021 09:32

mgiota added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Jul 20, 2021

mgiota added Theme: rac label obsolete release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jul 20, 2021

weltenwort requested changes Jul 20, 2021

View reviewed changes

mgiota added 7 commits July 20, 2021 21:56

delete serialized params

615b8fd

include group name in the reason

322fcca

cleanup

844313a

link to default metrics page

9238414

grab the value and threshold for the inventory item

323a2a6

Merge branch 'master' of github.com:elastic/kibana into 98360_metrics…

e59647f

…_rac_rule_registry

fix typo

944c3dc

fix check types

5b703c2

weltenwort reviewed Jul 21, 2021

View reviewed changes

.../infra/server/lib/alerting/inventory_metric_threshold/inventory_metric_threshold_executor.ts Outdated Show resolved Hide resolved

.../infra/server/lib/alerting/inventory_metric_threshold/inventory_metric_threshold_executor.ts Outdated Show resolved Hide resolved

mgiota force-pushed the 98360_metrics_rac_rule_registry branch 2 times, most recently from b136f30 to 193d243 Compare July 21, 2021 15:50

remove threshold and currentValue, the reason field will contain this…

94955dd

… info for combined conditions

mgiota force-pushed the 98360_metrics_rac_rule_registry branch from 193d243 to 94955dd Compare July 21, 2021 15:53

mgiota added 2 commits July 21, 2021 18:00

remove thereshold and value from the reason, soon will be replaced by…

1f3ce10

… indexed reason field

remove unnecessary export

db0ed1d

mgiota requested a review from weltenwort July 21, 2021 16:12

weltenwort approved these changes Jul 21, 2021

View reviewed changes

mgiota mentioned this pull request Jul 22, 2021

[RAC][Metrics UI] Link to an inventory item with the flyout open at a certain point in time #106497

Closed

mgiota merged commit eaa6dcb into elastic:master Jul 22, 2021

kibanamachine mentioned this pull request Jul 22, 2021

[7.x] [RAC] [Metrics UI] Register Inventory rule types with new RAC rules registry (#105706) #106512

Merged

mgiota mentioned this pull request Jul 22, 2021

[RAC][Metrics UI] Format reason in inventory metric executor #106513

Closed

mgiota deleted the 98360_metrics_rac_rule_registry branch January 4, 2022 10:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RAC] [Metrics UI] Register Inventory rule types with new RAC rules registry #105706

[RAC] [Metrics UI] Register Inventory rule types with new RAC rules registry #105706

mgiota commented Jul 15, 2021 •

edited

Loading

mgiota commented Jul 20, 2021

kibanamachine commented Jul 20, 2021

elasticmachine commented Jul 20, 2021

mgiota commented Jul 20, 2021 •

edited

Loading

weltenwort left a comment

mgiota commented Jul 21, 2021

weltenwort left a comment

weltenwort commented Jul 21, 2021

weltenwort left a comment •

edited

Loading

kibanamachine commented Jul 21, 2021

kibanamachine commented Jul 22, 2021

[RAC] [Metrics UI] Register Inventory rule types with new RAC rules registry #105706

[RAC] [Metrics UI] Register Inventory rule types with new RAC rules registry #105706

Conversation

mgiota commented Jul 15, 2021 • edited Loading

mgiota commented Jul 20, 2021

kibanamachine commented Jul 20, 2021

elasticmachine commented Jul 20, 2021

mgiota commented Jul 20, 2021 • edited Loading

weltenwort left a comment

Choose a reason for hiding this comment

mgiota commented Jul 21, 2021

weltenwort left a comment

Choose a reason for hiding this comment

weltenwort commented Jul 21, 2021

weltenwort left a comment • edited Loading

Choose a reason for hiding this comment

kibanamachine commented Jul 21, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Page load bundle

History

kibanamachine commented Jul 22, 2021

💚 Backport successful

mgiota commented Jul 15, 2021 •

edited

Loading

mgiota commented Jul 20, 2021 •

edited

Loading

weltenwort left a comment •

edited

Loading