Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Show event context #10513

Merged
merged 1 commit into from
Feb 22, 2017
Merged

[5.x] Show event context #10513

merged 1 commit into from
Feb 22, 2017

Conversation

elastic-jasper
Copy link
Contributor

Show event context

Backports PR #9198

Commit 1:
Add app to display discover entry context

Commit 2:
Extract multi-transclude workaround into directive

The multi-transclude attribute directive encapsulates the angular 1.4
workaround for multiple transclusion targets pioneered in kbn-top-nav
for separation of concerns and re-use.

There are some differences to the implementation in kbn-top-nav:

  • The directive logic is completely contained inside the link function
    and therefore won't interfere with other controllers.

  • The slots are declared as the attribute value.

  • The transcluded items are appended to the transclusion target's
    children instead of replacing the whole target. This preserves the
    attributes present on the target element.

  • Original sha: 05aedd8

  • Authored by Felix Stürmer [email protected] on 2016-11-21T14:56:20Z

Commit 3:
Add a generic local-navigation directive

The new directive <local-navigation> creates a navigation that uses
the ui-framework block styles of the same name. It utilizes the
previously introduced multi-transclude directive to provide the
following transclusion targets:

  • primaryLeft: The left side of the top row, often used for
    a title or breadcrumbs.
  • primaryRight: The right side of the top row, often used for menus
    and time pickers.
  • secondary: The bottom row for search bars or tab navigation.

While kbn-top-nav combined the concerns of rendering the surrounding
DOM as well as menu entries and the timepicker, this directive expects
those to be implemented separately and just placed in the navigation bar
via aforementioned transclusion slots.

A slot for dropdown panels has not yet been added.

Commit 4:
Use <local-navigation> for context size controls

Commit 5:
Wire up the context app state to the url

Commit 6:
Add basic link from discover to the context app

The doc viewer panel now contains a (hideous) link which displays the
context of the entry using the same column configuration. The location
and styling is hopefully subject to future improvement

Commit 7:
Change context view breadcrumbs

The breadcrumbs indicate that the context view is a sub-view of the
normal "Discover" view by including a link to it as the first item.

Commit 8:
Return promises from the reload and init actions

Commit 9:
Make the context size display editable

Commit 10:
Always sort on the index-pattern's time field

To focus on the use case of the app and to rule out numerous edge cases,
the context is always interpreted in relation the time field specified
in the index pattern.

Commit 11:
Improve doc and context link styling in docTable

Commit 12:
Fix font-awesome class name typo

Commit 13:
Hide context link for non-time-based index patterns

The link is hidden for index patterns that do not have a time field
defined, because the entry context view is designed to allow viewing the
surrounding entries with respect to a time ordering.

Commit 14:
Merge branch 'master' into discover-context-app

Commit 15:
Add setting to configure the default context size

The new setting context:defaultSize allows for customization of the
initial number of rows displayed when viewing an entry's context.

Commit 16:
Add setting to configure the context size step

The new setting context:step allows for customization of the step size
the context size is incremented/decremented by when using the buttons in
the context view.

Commit 17:
Enforce a minimal context size of 0

Commit 18:
Reimplement the local nav without multi-transclusion

The local navigation directive does not require the multi-transclusion
workaround anymore. Instead, it comes with a set of child directives
(localNavigationRow and localNavigationRowSection) that can be used
to compose a complete local navigation declaratively.

Commit 19:
Add visual indicator for first initialization

Commit 20:
Merge commit '10f7880' into discover-context-app

Commit 21:
Improve loading ui and behaviour, refactor state

The internal context app state is now managed using a unidirectional
data flow. On the ui side, controlling the size of the context now
happens via buttons at the top and bottom of the doc table or via text
inputs in the local navigation bar. Both now allow for independent
manipulation of the number of predecessors and successors. The two
halves of the table are also loaded independently and have independent
loading status indicators.

Commit 22:
Merge branch 'master' into discover-context-app

Commit 23:
Remove plus icons from "load more" buttons

Commit 24:
Merge branch 'master' into discover-context-app

Commit 25:
Merge branch 'master' into discover-context-app

Commit 26:
Fix AppState synchronization

Commit 27:
Merge branch 'master' into discover-context-app

Commit 28:
Fix linting errors

Commit 29:
Fix more linting errors

Commit 30:
Make anchor highlighting more prominent

Backports PR #9198

**Commit 1:**
Add app to display discover entry context

* Original sha: f80a169
* Authored by Felix Stürmer <[email protected]> on 2016-11-18T12:50:29Z

**Commit 2:**
Extract multi-transclude workaround into directive

The `multi-transclude` attribute directive encapsulates the angular 1.4
workaround for multiple transclusion targets pioneered in `kbn-top-nav`
for separation of concerns and re-use.

There are some differences to the implementation in `kbn-top-nav`:
* The directive logic is completely contained inside the link function
  and therefore won't interfere with other controllers.
* The slots are declared as the attribute value.
* The transcluded items are appended to the transclusion target's
  children instead of replacing the whole target. This preserves the
  attributes present on the target element.

* Original sha: 05aedd8
* Authored by Felix Stürmer <[email protected]> on 2016-11-21T14:56:20Z

**Commit 3:**
Add a generic local-navigation directive

The new directive `<local-navigation>` creates a navigation that uses
the ui-framework block styles of the same name. It utilizes the
previously introduced `multi-transclude` directive to provide the
following transclusion targets:

* `primaryLeft`: The left side of the top row, often used for
  a title or breadcrumbs.
* `primaryRight`: The right side of the top row, often used for menus
  and time pickers.
* `secondary`: The bottom row for search bars or tab navigation.

While `kbn-top-nav` combined the concerns of rendering the surrounding
DOM as well as menu entries and the timepicker, this directive expects
those to be implemented separately and just placed in the navigation bar
via aforementioned transclusion slots.

A slot for dropdown panels has not yet been added.

* Original sha: 2e422f7
* Authored by Felix Stürmer <[email protected]> on 2016-11-21T15:04:50Z

**Commit 4:**
Use `<local-navigation>` for context size controls

* Original sha: 89b31e9
* Authored by Felix Stürmer <[email protected]> on 2016-11-21T15:07:48Z

**Commit 5:**
Wire up the context app state to the url

* Original sha: 3227016
* Authored by Felix Stürmer <[email protected]> on 2016-11-21T15:09:34Z

**Commit 6:**
Add basic link from discover to the context app

The doc viewer panel now contains a (hideous) link which displays the
context of the entry using the same column configuration. The location
and styling is hopefully subject to future improvement

* Original sha: ef78a3c
* Authored by Felix Stürmer <[email protected]> on 2016-11-21T15:12:38Z

**Commit 7:**
Change context view breadcrumbs

The breadcrumbs indicate that the context view is a sub-view of the
normal "Discover" view by including a link to it as the first item.

* Original sha: be355d8
* Authored by Felix Stürmer <[email protected]> on 2016-11-22T19:14:30Z

**Commit 8:**
Return promises from the reload and init actions

* Original sha: b2db703
* Authored by Felix Stürmer <[email protected]> on 2016-11-22T19:16:53Z

**Commit 9:**
Make the context size display editable

* Original sha: c3d7459
* Authored by Felix Stürmer <[email protected]> on 2016-11-22T19:19:11Z

**Commit 10:**
Always sort on the index-pattern's time field

To focus on the use case of the app and to rule out numerous edge cases,
the context is always interpreted in relation the time field specified
in the index pattern.

* Original sha: 9e5986c
* Authored by Felix Stürmer <[email protected]> on 2016-11-23T13:44:34Z

**Commit 11:**
Improve doc and context link styling in docTable

* Original sha: d64f938
* Authored by Felix Stürmer <[email protected]> on 2016-11-23T14:54:36Z

**Commit 12:**
Fix font-awesome class name typo

* Original sha: 2acc123
* Authored by Felix Stürmer <[email protected]> on 2016-11-23T14:58:08Z

**Commit 13:**
Hide context link for non-time-based index patterns

The link is hidden for index patterns that do not have a time field
defined, because the entry context view is designed to allow viewing the
surrounding entries with respect to a time ordering.

* Original sha: 4991bd8
* Authored by Felix Stürmer <[email protected]> on 2016-11-23T15:11:22Z

**Commit 14:**
Merge branch 'master' into discover-context-app

* Original sha: 1bb189d
* Authored by Felix Stürmer <[email protected]> on 2016-12-05T12:39:18Z

**Commit 15:**
Add setting to configure the default context size

The new setting `context:defaultSize` allows for customization of the
initial number of rows displayed when viewing an entry's context.

* Original sha: e10f458
* Authored by Felix Stürmer <[email protected]> on 2016-12-05T14:57:49Z

**Commit 16:**
Add setting to configure the context size step

The new setting `context:step` allows for customization of the step size
the context size is incremented/decremented by when using the buttons in
the context view.

* Original sha: 123d6b0
* Authored by Felix Stürmer <[email protected]> on 2016-12-05T15:01:06Z

**Commit 17:**
Enforce a minimal context size of 0

* Original sha: dbaed4f
* Authored by Felix Stürmer <[email protected]> on 2016-12-05T15:04:48Z

**Commit 18:**
Reimplement the local nav without multi-transclusion

The local navigation directive does not require the multi-transclusion
workaround anymore. Instead, it comes with a set of child directives
(`localNavigationRow` and `localNavigationRowSection`) that can be used
to compose a complete local navigation declaratively.

* Original sha: 840278f
* Authored by Felix Stürmer <[email protected]> on 2016-12-06T15:21:51Z

**Commit 19:**
Add visual indicator for first initialization

* Original sha: 4730c77
* Authored by Felix Stürmer <[email protected]> on 2016-12-06T16:35:37Z

**Commit 20:**
Merge commit '10f7880' into discover-context-app

* Original sha: 2054287
* Authored by Felix Stürmer <[email protected]> on 2016-12-13T12:04:44Z

**Commit 21:**
Improve loading ui and behaviour, refactor state

The internal context app state is now managed using a unidirectional
data flow. On the ui side, controlling the size of the context now
happens via buttons at the top and bottom of the doc table or via text
inputs in the local navigation bar. Both now allow for independent
manipulation of the number of predecessors and successors. The two
halves of the table are also loaded independently and have independent
loading status indicators.

* Original sha: a9c96aa
* Authored by Felix Stürmer <[email protected]> on 2016-12-13T18:55:58Z

**Commit 22:**
Merge branch 'master' into discover-context-app

* Original sha: a2b1456
* Authored by Felix Stürmer <[email protected]> on 2016-12-13T18:59:57Z

**Commit 23:**
Remove plus icons from "load more" buttons

* Original sha: bb1b056
* Authored by Felix Stürmer <[email protected]> on 2016-12-13T19:16:34Z

**Commit 24:**
Merge branch 'master' into discover-context-app

* Original sha: 36c9b17
* Authored by Felix Stürmer <[email protected]> on 2016-12-13T21:47:16Z

**Commit 25:**
Merge branch 'master' into discover-context-app

* Original sha: 72e7faf
* Authored by Felix Stürmer <[email protected]> on 2016-12-14T11:49:07Z

**Commit 26:**
Fix AppState synchronization

* Original sha: 366962a
* Authored by Felix Stürmer <[email protected]> on 2016-12-15T14:54:59Z

**Commit 27:**
Merge branch 'master' into discover-context-app

* Original sha: a98d967
* Authored by Felix Stürmer <[email protected]> on 2016-12-15T14:57:32Z

**Commit 28:**
Fix linting errors

* Original sha: 778d3ce
* Authored by Felix Stürmer <[email protected]> on 2016-12-15T15:00:33Z

**Commit 29:**
Fix more linting errors

* Original sha: 46d8472
* Authored by Felix Stürmer <[email protected]> on 2016-12-15T15:10:11Z

**Commit 30:**
Make anchor highlighting more prominent

* Original sha: 3ae8a5d
* Authored by Felix Stürmer <[email protected]> on 2016-12-16T12:41:47Z
@weltenwort weltenwort merged commit 134ece5 into 5.x Feb 22, 2017
@epixa epixa deleted the jasper/backport/9198/5.x branch February 28, 2017 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants