Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix time shift bug #102528

Merged
merged 10 commits into from
Jun 21, 2021
Merged

[Lens] Fix time shift bug #102528

merged 10 commits into from
Jun 21, 2021

Conversation

flash1293
Copy link
Contributor

Fixes #102175

This PR makes sure the time range is resolved when calculating the shift for "previous" without time range.

@flash1293 flash1293 added auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens Team:AppServices Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jun 17, 2021
@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review June 18, 2021 11:44
@flash1293 flash1293 requested a review from a team as a code owner June 18, 2021 11:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

ppisljar
ppisljar approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

src/plugins/data/common/search/aggs/agg_configs.ts
@@ -127,6 +127,15 @@ export class AggConfigs {
this.aggs.forEach(updateAggTimeRange);
}

getResolvedTimeRange() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add docs

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 831.1KB 831.2KB +156.0B
Unknown metric groups

API count

id before after diff
data 3831 3833 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 7765fc7 into elastic:master Jun 21, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 21, 2021
@flash1293 @kibanamachine
[Lens] Fix time shift bug (elastic#102528)
4308084
@kibanamachine kibanamachine mentioned this pull request Jun 21, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 21, 2021
@kibanamachine @flash1293
[Lens] Fix time shift bug (#102528) (#102752)
db83874 
Co-authored-by: Joe Reuter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Time shift does not work for non date-histogram chart, previous shift and dynamic time range
4 participants
@flash1293 @elasticmachine @kibanamachine @ppisljar