Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Index Patterns] Cover field editor with a11y tests #101888

Merged
merged 3 commits into from
Jun 14, 2021
Merged

[Index Patterns] Cover field editor with a11y tests #101888

merged 3 commits into from
Jun 14, 2021

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Jun 10, 2021 •
edited
Loading

Summary

Close #92536

If I got this right, then this all it takes to add an a11y test for that piece of UI. No new errors came up, so no a11y fixes

@Dosant Dosant added Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Project:Accessibility Team:AppServices release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 and removed v8.0 labels Jun 10, 2021
@Dosant Dosant marked this pull request as ready for review June 10, 2021 14:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@Dosant Dosant requested review from mattkime and a team June 10, 2021 14:39
@mattkime mattkime requested a review from myasonik June 10, 2021 15:13
@mattkime
Copy link
Contributor

lets get feedback from @myasonik - its my first time through this as well.

myasonik
myasonik suggested changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@myasonik myasonik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Yay tests! Thanks!

Sorry, one issue that's ultimately my fault (no docs on it) but means a code change for you.

@Dosant Dosant requested a review from myasonik June 14, 2021 12:00
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

myasonik
myasonik approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Dosant Dosant merged commit dbe6bfd into elastic:master Jun 14, 2021
@Dosant Dosant mentioned this pull request Jun 14, 2021
Merged
Dosant added a commit to Dosant/kibana that referenced this pull request Jun 14, 2021
@Dosant
[Index Patterns] Cover field editor with a11y tests (elastic#101888)
3137a72
Dosant added a commit that referenced this pull request Jun 14, 2021
@Dosant
[Index Patterns] Cover field editor with a11y tests (#101888) (#102074)
99e7c90
cuff-links pushed a commit to cuff-links/kibana that referenced this pull request Jun 15, 2021
@Dosant
[Index Patterns] Cover field editor with a11y tests (elastic#101888)
b321c68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myasonik myasonik myasonik approved these changes

@mattkime mattkime Awaiting requested review from mattkime

Assignees
No one assigned
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Index pattern field editor - add accessibility tests
5 participants
@Dosant @elasticmachine @mattkime @kibanamachine @myasonik