Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adds functional tests for anomaly detection job custom URLs #100455

Merged
merged 7 commits into from
May 26, 2021
Merged

[ML] Adds functional tests for anomaly detection job custom URLs #100455

merged 7 commits into from
May 26, 2021

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented May 24, 2021 •
edited
Loading

Summary

Adds functional tests for adding, editing and deleting custom URLs from anomaly detection jobs.

  • Creating custom URL to Discover
  • Creating custom URL to Dashboard
  • Creating 'other' type custom URL
  • Editing a custom URL
  • Deleting a custom URL
  • Tests custom URL to Discover
  • Tests custom URL to Dashboard

Checklist

Delete any items that are not applicable to this PR.

@peteharverson peteharverson self-assigned this May 24, 2021
@peteharverson peteharverson requested a review from a team as a code owner May 24, 2021 11:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson mentioned this pull request May 24, 2021
Closed
15 tasks
@peteharverson peteharverson requested review from qn895 and removed request for jgowdyelastic May 24, 2021 15:36
@pheyos
Copy link
Member

pheyos commented May 25, 2021 •
edited
Loading

Checking test stability in a flaky test runner job ... no failure in 50 runs ✔️

@qn895
Copy link
Member

qn895 commented May 25, 2021

LGTM 🎉

alvarezmelissa87
alvarezmelissa87 approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

pheyos
pheyos reviewed May 26, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see these functional tests coming 🎉
Left a few suggestions.

pheyos
pheyos approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@peteharverson
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +864.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -342

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @peteharverson

@peteharverson peteharverson merged commit f77ff2d into elastic:master May 26, 2021
@peteharverson peteharverson deleted the ml-custom-urls-func-tests branch May 26, 2021 16:48
@peteharverson peteharverson mentioned this pull request May 26, 2021
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request May 26, 2021
@peteharverson @kibanamachine
[ML] Adds functional tests for anomaly detection job custom URLs (ela…
bb646f3 
…stic#100455)

* [ML] Adds functional tests for anomaly detection job custom URLs

* [ML] Remove debug test tag from custom URL tests

* [ML] Update custom URL editor Jest snapshots

* [ML] Clean up in embeddables tests to fix dashboard test

* [ML] Delete test dashboard after test suites complete

* [ML] Edits to custom URL tests following review

Co-authored-by: Kibana Machine <[email protected]>
peteharverson added a commit that referenced this pull request May 26, 2021
@peteharverson @kibanamachine
[ML] Adds functional tests for anomaly detection job custom URLs (#10…
a89dd49 
…0455) (#100706)

* [ML] Adds functional tests for anomaly detection job custom URLs

* [ML] Remove debug test tag from custom URL tests

* [ML] Update custom URL editor Jest snapshots

* [ML] Clean up in embeddables tests to fix dashboard test

* [ML] Delete test dashboard after test suites complete

* [ML] Edits to custom URL tests following review

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@qn895 qn895 qn895 approved these changes

Assignees

@peteharverson peteharverson

Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes review test_ui_functional v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@peteharverson @elasticmachine @pheyos @qn895 @kibanamachine @alvarezmelissa87