-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Integration input groups, phase 1 #93315
Comments
Pinging @elastic/fleet (Team:Fleet) |
@ph not sure what this issue is for since we're tracking related changes in the linked Meta issue |
@ph I added the requirements for fleet UI in the description. @mostlyjason can you take a pass at reviewing the reqs? |
@mukeshelastic do you mean it shows only the dynamodb metrics configuration is enabled and the rest of the options in metrics and logs are disabled?
I think the datastreams dashboards are defined at the package level, so they would see a list of all the AWS dashboards, of which dynamodb is one |
That is right, Users will need to drill down from AWS dashboards into the dynamodb specific dashboard. |
FYI Kibana work on this is blocked until work is done to package registry: elastic/package-spec#144 |
@kaiyan-sheng is currently building the AWS package based on the new structure. Once ready it should enable all related work. |
I left a question regarding package-level |
@sorantis Can you help clarify what AWS tiles you expect to see on "Installed integrations" tab once the AWS package installed? Just the main AWS tile or main+all integrations tiles like in "All integrations" tab? I'm thinking it might be a better UX to just show the main AWS tile? Edit: Can you also clarify what you expect to see in the "All integrations" tab if the user has not entered any search queries? |
@jen-huang All views should show granular integrations, i.e. the second screenshot from your questions. Since we maintain package <-> policy_template relationship, at some point we might want to reflect this nested structure in the UI, bit for now the user should be able to see granular integrations. The AWS service tiles looking good by the way :) |
@sorantis I don't have a strong opinion on only showing granular integrations vs showing both the overall package+its integrations as tiles. This part of the issue requirement confused me as I take it to mean that the AWS package tile is present in addition to the integration tiles: Re: showing integration tiles on Installed integrations page - the way the code is today, all the AWS integrations will show up here even if the user "only" added DynamoDB (as an example) because we install the entire AWS package at that time. Are there any UX concerns here? (That's why I thought only showing the AWS tile on the installed tab might be better, but it is nice to have the tiles be consistent.) Edit: I left some additional thoughts related to this and the registry work here: elastic/package-registry#685 (comment) |
We should perhaps change the term "installed integrations" here as it is kind of confusing. Lets assume you have AWS with DynamoDB and S3. Now "DynamoDB" and "S3" are used. Assuming "S3" is not used in any policy anymore, what will show here? It is not that "S3" was uninstalled but it is not used anymore. Same if AWS with S3 is "used" multiple times, I guess it is only shown once? |
Hi @EricDavisX
As mentioned under #93315 (comment) Please let us know if anything else is required from our end. |
Hi @EricDavisX Thanks |
@amolnater-qasource Thanks for the thorough testing! This requirement was changed slightly, this is what is expected:
|
Requirements
After the input groups support is added in fleet UI, :
The text was updated successfully, but these errors were encountered: