Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data plugin] Wrong caching for Index pattern fields #84666

Closed
alexwizp opened this issue Dec 1, 2020 · 3 comments · Fixed by #87116
Closed

[Data plugin] Wrong caching for Index pattern fields #84666

alexwizp opened this issue Dec 1, 2020 · 3 comments · Fixed by #87116

Comments

@alexwizp
Copy link
Contributor

alexwizp commented Dec 1, 2020

Kibana version:
master

Describe the bug:
While working on #84336 I encountered strange caching of the pattern index fields on the server side of Kibana.
To reproduce this issue please checkout #84612

Steps to reproduce:

  1. Install some of Sample Data

  2. Go to Stack Management -> Index patterns -> your index (e.g. kibana_sample_data_ecommerce)

  3. Set custom label for some field (e.g. order_date -> 'custom label (order date)')
    image

  4. After saving go to TSVB and try to select somewhere field from step 3
    image


Expected behavior:
I expect to see custom label (order date)


  1. To be sure this isn't a UI issue, let's reload the entire page and open
    image

  2. Now let's restart Kibana server. Custom label was applied
    image

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@mattkime
Copy link
Contributor

mattkime commented Dec 3, 2020

I took a look but I'm having trouble reproducing the problem. As best I can tell any changes made in the index pattern saved object are reflected after saving in index pattern management and navigating to TSVB

@stratoula
Copy link
Contributor

@mattkime I have the same problem. I change the label of a field and when I am trying to use it on TSVB I can't see the label. If I restart the server everything works fine

alexwizp added a commit to alexwizp/kibana that referenced this issue Jan 4, 2021
alexwizp added a commit that referenced this issue Jan 5, 2021
* [Data plugin] Wrong caching for Index pattern fields

Closes: #84666

* remove can update index_pattern fields test

* fix tests

Co-authored-by: Kibana Machine <[email protected]>
alexwizp added a commit to alexwizp/kibana that referenced this issue Jan 5, 2021
* [Data plugin] Wrong caching for Index pattern fields

Closes: elastic#84666

* remove can update index_pattern fields test

* fix tests

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts
alexwizp added a commit to alexwizp/kibana that referenced this issue Jan 5, 2021
* [Data plugin] Wrong caching for Index pattern fields

Closes: elastic#84666

* remove can update index_pattern fields test

* fix tests

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts
alexwizp added a commit that referenced this issue Jan 6, 2021
* [Data plugin] Wrong caching for Index pattern fields

Closes: #84666

* remove can update index_pattern fields test

* fix tests

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts
alexwizp added a commit that referenced this issue Jan 6, 2021
* [Data plugin] Wrong caching for Index pattern fields

Closes: #84666

* remove can update index_pattern fields test

* fix tests

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants