Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Move expectSnapshot to @kbn/test #80292

Closed
dgieselaar opened this issue Oct 13, 2020 · 2 comments · Fixed by #82932
Closed

[APM] Move expectSnapshot to @kbn/test #80292

dgieselaar opened this issue Oct 13, 2020 · 2 comments · Fixed by #82932
Assignees
@dgieselaar
Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services. technical debt Improvement of the software architecture and operational architecture

Comments

@dgieselaar
Copy link
Member

@spalger suggested to move expectSnapshot to @kbn/test, in order for other teams to use it & make it more easily available (e.g. via globals).
@dgieselaar dgieselaar added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Oct 13, 2020
@dgieselaar dgieselaar self-assigned this Oct 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv
Copy link
Member

Great, idea!

@sorenlouv sorenlouv added [zube]: Inbox technical debt Improvement of the software architecture and operational architecture and removed [zube]: Inbox labels Oct 19, 2020
@dgieselaar dgieselaar mentioned this issue Nov 9, 2020
Merged
dgieselaar added a commit to dgieselaar/kibana that referenced this issue Nov 9, 2020
@dgieselaar
Make expectSnapshot available in all functional test runs
6e95ee7 
Closes elastic#80292.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgieselaar dgieselaar

Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make expectSnapshot available in all functional test runs dgieselaar/kibana
3 participants
@sorenlouv @dgieselaar @elasticmachine