-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing a saved object from Management UI can corrupt the saved object #66542
Labels
blocker
bug
Fixes for quality problems that affect the customer experience
Feature:Kibana Management
Feature label for Data Views, Advanced Setting, Saved Object management pages
Feature:Saved Objects
regression
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v7.8.0
Comments
Pinging @elastic/kibana-platform (Team:Platform) |
Caused by the removal of // Special handling for references which isn't within "attributes"
createField(fields, obj.references, 'references'); During the migration of https://github.com/elastic/kibana/pull/59490/files#diff-1ae745e2ea3c5e223fe24671b08f4e20
|
joshdover
added a commit
to joshdover/kibana
that referenced
this issue
May 14, 2020
joshdover
added a commit
that referenced
this issue
May 14, 2020
joshdover
added a commit
to joshdover/kibana
that referenced
this issue
May 15, 2020
joshdover
added a commit
to joshdover/kibana
that referenced
this issue
May 15, 2020
# Conflicts: # docs/CHANGELOG.asciidoc
joshdover
added a commit
that referenced
this issue
May 17, 2020
joshdover
added a commit
that referenced
this issue
May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocker
bug
Fixes for quality problems that affect the customer experience
Feature:Kibana Management
Feature label for Data Views, Advanced Setting, Saved Object management pages
Feature:Saved Objects
regression
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v7.8.0
Kibana version:
7.8 BC2
Describe the bug:
When editing and saving a
dashboard
from theManagement UI
, the saved object lose all itsreferences
to each embeddable, causing two main issues:Steps to reproduce:
Sample web log
sample dataset[Logs] Web Traffic
dashboard: it should render correctlyStack Monitoring UI
->Saved object
andInspect
the[Logs] Web Traffic
saved object.references
always shows an empty array also if, inspecting the network or the real object saved into kibana, thereferences
array has all the references to the used embeddable in the dashboard.panelJSON
or simply click saveExpected behavior:
The
Saved Object UI
should show and save all the references correctly.Screenshots (if relevant):

Errors in browser console (if relevant):
none
Provide logs and/or server output (if relevant):
no relevant logs
Any additional context:
I’ve investigated a bit more and I’ve found that this PR is probably the root cause: #61700
Seems that there is an issue when converting the saved object to the field list to be rendered on the saved object UI.
This can be located in
src/plugins/saved_objects_management/public/lib/create_field_list.ts
and consequentially insrc/plugins/saved_objects_management/public/management_section/object_view/components/form.tsx
Seems that we are trying to get the
references
array from theattributes
property of theSimpleSavedObject
but they live on the root level of the same object.The text was updated successfully, but these errors were encountered: