Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Use platform history object #65682

Closed
dgieselaar opened this issue May 7, 2020 · 5 comments · Fixed by #74328
Closed

[APM] Use platform history object #65682

dgieselaar opened this issue May 7, 2020 · 5 comments · Fixed by #74328
Assignees
Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services. technical debt Improvement of the software architecture and operational architecture v7.10.0

Comments

@dgieselaar
Copy link
Member

dgieselaar commented May 7, 2020

We are currently using a hash-based history object. However, in NP, Platform injects its own (HTML5-based) history object that we should use. This would allow us to get rid of hash-based routing and create less friction when navigating between different Kibana plugins/apps.

See #64804, which was addressed with a temporary workaround

Related: #51963

@dgieselaar dgieselaar added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label May 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith
Copy link
Contributor

smith commented May 8, 2020

#63443 makes it so links to Discover and Home (tutorials) don't cause a full refresh. That PR fixed the links to make them use the correct locations, but still cause a full refresh because we're not using the above or the navigateToApp service.

@smith
Copy link
Contributor

smith commented May 8, 2020

#65164 may allow us to have more links work without the router changes or having to use navigateToApp.

@dgieselaar
Copy link
Member Author

dgieselaar commented May 8, 2020 via email

@sorenlouv sorenlouv added [zube]: Backlog v7.9.0 technical debt Improvement of the software architecture and operational architecture labels May 11, 2020
@smith
Copy link
Contributor

smith commented May 15, 2020

PR #65164 is now closed (due to some issue with opt in/out and complexity related to multiple event handlers) and issue #58751 is open with a discussion of alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services. technical debt Improvement of the software architecture and operational architecture v7.10.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants