Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kbn/optimizer] changes to dependencies of package are not considered in cache key #58077

Closed
spalger opened this issue Feb 20, 2020 · 1 comment · Fixed by #58176
Closed

[kbn/optimizer] changes to dependencies of package are not considered in cache key #58077

spalger opened this issue Feb 20, 2020 · 1 comment · Fixed by #58176
Labels
bug Fixes for quality problems that affect the customer experience Team:Operations Team label for Operations Team

Comments

@spalger
Copy link
Contributor

spalger commented Feb 20, 2020

In the @kbn/optimizer we use git to determine a cache key for the optimizer, but somehow we overlooked the importance of changes in dependencies of @kbn/optimizer I'm about to make a change to the @kbn/ui-shared-deps package, which is used by the optimizer to determine which packages should be external-ized. If we don't consider this a part of the optimizer cache key then invalid bundles will be used and things will be broken for dev. For the next day I'll manually bust the cache by making pointless changes to the optimizer when necessary, but I'm working on fixing this ASAP.
@spalger spalger added bug Fixes for quality problems that affect the customer experience Team:Operations Team label for Operations Team labels Feb 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

spalger added a commit to spalger/kibana that referenced this issue Feb 20, 2020
@spalger
include a cache buster to counteract issue elastic#58077
3450f99
spalger pushed a commit that referenced this issue Feb 20, 2020
add monaco to kbn/ui-shared-deps and load required features for all u…
4aedf2b 
…ses (#58075)

* add monaco to kbn/ui-shared-deps and load required features for all uses

* forgot to save a change

* remove unused imports

* include a cache buster to counteract issue #58077

* include monaco.ts in ts project
spalger pushed a commit to spalger/kibana that referenced this issue Feb 20, 2020
@spalger
add monaco to kbn/ui-shared-deps and load required features for all u…
625d0c4 
…ses (elastic#58075)

* add monaco to kbn/ui-shared-deps and load required features for all uses

* forgot to save a change

* remove unused imports

* include a cache buster to counteract issue elastic#58077

* include monaco.ts in ts project
@spalger spalger mentioned this issue Feb 20, 2020
Merged
spalger pushed a commit that referenced this issue Feb 20, 2020
[7.x] add monaco to kbn/ui-shared-deps and load required features for…
23e3ce7 
… all uses (#58075) (#58167)

* add monaco to kbn/ui-shared-deps and load required features for all uses (#58075)

* add monaco to kbn/ui-shared-deps and load required features for all uses

* forgot to save a change

* remove unused imports

* include a cache buster to counteract issue #58077

* include monaco.ts in ts project

* update yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Team:Operations Team label for Operations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[kbn/optimizer] include bootstrap cache key in optimizer cache key spalger/kibana
2 participants
@spalger @elasticmachine