Adding filter pills causes double fetch in discover and dashboards

[flash1293]

Kibana version: master

Elasticsearch version:

Server OS version:

Browser version:

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):

Describe the bug: src/plugins/data/public/query/filter_manager/lib/mappers/map_phrase.ts adds a formatter function to the filter object. However the filter in the appState won't have this property. This causes the filter manager to trigger subscribers to fetch because the filter_manager checks equality by a simple deep equality check: https://github.com/elastic/kibana/blob/master/src/plugins/data/public/query/filter_manager/filter_manager.ts#L92

It looks like the same thing is also happening in dashboards.

In case of discover this causes fetch to be called two times:

• Filters are changed in the top nav component
• Discover calls setFilters, which causes the first fetch to be dispatched
• New filters are stored in the global state
• The interval checker in https://github.com/elastic/kibana/blob/master/src/legacy/core_plugins/data/public/filter/filter_manager/filter_state_manager.ts#L58 picks up the change, pulls the filters from the appState and compares them to the filters stored in the filter manager - they are different because the appState filter doesn't have the formatter function property value (maybe because it gets deserialized from the url?), but the filterManager one has.
• This is enough difference for the filter state manager to setFilters again

Steps to reproduce:

1. Go to discover
2. Add a filter pill on a keyword field
3. Observe two requests being dispatched

Expected behavior:

Screenshots (if relevant):

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[lukeelmers]

@lizozom @flash1293 can this be closed?

[flash1293]

Yep, can be closed.