Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show total does not render any value but count in datatable #34046

Closed
dadoonet opened this issue Mar 28, 2019 · 3 comments · Fixed by #34169
Closed

Show total does not render any value but count in datatable #34046

dadoonet opened this issue Mar 28, 2019 · 3 comments · Fixed by #34169
Assignees
@lukeelmers
Labels
bug Fixes for quality problems that affect the customer experience Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:Data Table Data table visualization feature PR sent regression

Comments

@dadoonet
Copy link
Member

Kibana version: 7.0.0-rc1

I'm creating a datatable where I'm splitting the data using a terms aggregation.
I want to use the Show total feature.

When the total function is set to count, I'm getting numbers at the bottom (4 and 4).

721CA296-8841-4601-938E-14DAFCB5EE58

When I'm using any other function like sum, I'm not getting anything at the bottom.

E45F8428-A583-4ED7-8378-DD440FF1F97F
@timroes timroes added bug Fixes for quality problems that affect the customer experience Feature:Data Table Data table visualization feature Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) :AppArch labels Mar 28, 2019
@timroes
Copy link
Contributor

timroes commented Mar 28, 2019

@lukeelmers Since we didn't change anything in the datatable implementation I suspect something going on with tabify here? Thought I ping you since you're the best into the table infrastructure.

@lukeelmers
Copy link
Member

@timroes Not a tabify issue, but something that seems to have gone wrong since #28746. I'll open a fix shortly.

@lukeelmers lukeelmers self-assigned this Mar 29, 2019
lukeelmers added a commit to lukeelmers/kibana that referenced this issue Mar 29, 2019
@lukeelmers
Fix missing column totals in data table.
0e056c7 
The data table relies on `isNumeric` and `isDate` params to be defined
on each dimension so that it can determine how to calculate and format
column totals when they are enabled.

These params were missing from the `getSchemas` utility, causing the
data table to render empty rows for totals.

Fixes elastic#34046
@lukeelmers lukeelmers mentioned this issue Mar 29, 2019
Merged
@lukeelmers
Copy link
Member

PR fixing this is up at #34169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukeelmers lukeelmers

Labels
bug Fixes for quality problems that affect the customer experience Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:Data Table Data table visualization feature PR sent regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing column totals in data table. lukeelmers/kibana
3 participants
@dadoonet @timroes @lukeelmers