-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
essql errors just show "check server logs" #32356
Labels
blocker
bug
Fixes for quality problems that affect the customer experience
Feature:Canvas
PR sent
regression
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
v6.7.0
v7.0.0
Comments
Pinging @elastic/kibana-canvas |
w33ble
added a commit
that referenced
this issue
Mar 8, 2019
…unctions (#32600) Closes #32356 This PR fixes two issues. The first there was an issue filed, #32356: - Show non-Boom errors instead of asking users to look at server logs - Also write the error to the server when asking them to look there ### Before  *If the function failed for some reason, this is all you'd ever see* ### After  *Errors are shown to the user*  *Code errors bubble up correctly as well* --- The other I didn't bother opening an issue for: - Fixes issue where functions that return `null` produce an error message - `null` is a valid thing to return, it's only `undefined` that causes a problem - This was only a problem for server functions that return `null` (currently, none of them do) - Introduced in #31298 - Discovered when I ran into casting problems (see #32597) ### Before  ### After 
w33ble
added a commit
to w33ble/kibana
that referenced
this issue
Mar 8, 2019
…unctions (elastic#32600) Closes elastic#32356 This PR fixes two issues. The first there was an issue filed, elastic#32356: - Show non-Boom errors instead of asking users to look at server logs - Also write the error to the server when asking them to look there ### Before  *If the function failed for some reason, this is all you'd ever see* ### After  *Errors are shown to the user*  *Code errors bubble up correctly as well* --- The other I didn't bother opening an issue for: - Fixes issue where functions that return `null` produce an error message - `null` is a valid thing to return, it's only `undefined` that causes a problem - This was only a problem for server functions that return `null` (currently, none of them do) - Introduced in elastic#31298 - Discovered when I ran into casting problems (see elastic#32597) ### Before  ### After 
w33ble
added a commit
to w33ble/kibana
that referenced
this issue
Mar 8, 2019
…unctions (elastic#32600) Closes elastic#32356 This PR fixes two issues. The first there was an issue filed, elastic#32356: - Show non-Boom errors instead of asking users to look at server logs - Also write the error to the server when asking them to look there  *If the function failed for some reason, this is all you'd ever see*  *Errors are shown to the user*  *Code errors bubble up correctly as well* --- The other I didn't bother opening an issue for: - Fixes issue where functions that return `null` produce an error message - `null` is a valid thing to return, it's only `undefined` that causes a problem - This was only a problem for server functions that return `null` (currently, none of them do) - Introduced in elastic#31298 - Discovered when I ran into casting problems (see elastic#32597)  
w33ble
added a commit
to w33ble/kibana
that referenced
this issue
Mar 8, 2019
…unctions (elastic#32600) Closes elastic#32356 This PR fixes two issues. The first there was an issue filed, elastic#32356: - Show non-Boom errors instead of asking users to look at server logs - Also write the error to the server when asking them to look there  *If the function failed for some reason, this is all you'd ever see*  *Errors are shown to the user*  *Code errors bubble up correctly as well* --- The other I didn't bother opening an issue for: - Fixes issue where functions that return `null` produce an error message - `null` is a valid thing to return, it's only `undefined` that causes a problem - This was only a problem for server functions that return `null` (currently, none of them do) - Introduced in elastic#31298 - Discovered when I ran into casting problems (see elastic#32597)  
w33ble
added a commit
that referenced
this issue
Mar 8, 2019
…unctions (#32600) (#32797) Closes #32356 This PR fixes two issues. The first there was an issue filed, #32356: - Show non-Boom errors instead of asking users to look at server logs - Also write the error to the server when asking them to look there  *If the function failed for some reason, this is all you'd ever see*  *Errors are shown to the user*  *Code errors bubble up correctly as well* --- The other I didn't bother opening an issue for: - Fixes issue where functions that return `null` produce an error message - `null` is a valid thing to return, it's only `undefined` that causes a problem - This was only a problem for server functions that return `null` (currently, none of them do) - Introduced in #31298 - Discovered when I ran into casting problems (see #32597)  
w33ble
added a commit
that referenced
this issue
Mar 8, 2019
…unctions (#32600) (#32792) Closes #32356 This PR fixes two issues. The first there was an issue filed, #32356: - Show non-Boom errors instead of asking users to look at server logs - Also write the error to the server when asking them to look there ### Before  *If the function failed for some reason, this is all you'd ever see* ### After  *Errors are shown to the user*  *Code errors bubble up correctly as well* --- The other I didn't bother opening an issue for: - Fixes issue where functions that return `null` produce an error message - `null` is a valid thing to return, it's only `undefined` that causes a problem - This was only a problem for server functions that return `null` (currently, none of them do) - Introduced in #31298 - Discovered when I ran into casting problems (see #32597) ### Before  ### After 
w33ble
added a commit
that referenced
this issue
Mar 8, 2019
…unctions (#32600) (#32794) Closes #32356 This PR fixes two issues. The first there was an issue filed, #32356: - Show non-Boom errors instead of asking users to look at server logs - Also write the error to the server when asking them to look there  *If the function failed for some reason, this is all you'd ever see*  *Errors are shown to the user*  *Code errors bubble up correctly as well* --- The other I didn't bother opening an issue for: - Fixes issue where functions that return `null` produce an error message - `null` is a valid thing to return, it's only `undefined` that causes a problem - This was only a problem for server functions that return `null` (currently, none of them do) - Introduced in #31298 - Discovered when I ran into casting problems (see #32597)  
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocker
bug
Fixes for quality problems that affect the customer experience
Feature:Canvas
PR sent
regression
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
v6.7.0
v7.0.0
Kibana version: 6.7+
Describe the bug:
When you put an invalid query in the
essql
function, like querying an non-existent index or try to use a field that doesn't exist, all you see is this:[essql] > See server logs for details.
But I'm a user, I can't see the logs, which are actually super helpful:
We should surface the error message in the app, otherwise it's nearly impossible to figure out what you did wrong.
This is also a regression, in 6.6 we did show the error we got from Elasticsearch.
Steps to reproduce:
essql query="select username from not_an_index"
The text was updated successfully, but these errors were encountered: