Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Testing the new borealis theme in the editor #200160

Closed
stratoula opened this issue Nov 14, 2024 · 1 comment · Fixed by #203692
Closed

[ES|QL] Testing the new borealis theme in the editor #200160

stratoula opened this issue Nov 14, 2024 · 1 comment · Fixed by #203692
Assignees
@ryankeairns
Labels
enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana v8.18.0

Comments

@stratoula
Copy link
Contributor

Describe the feature:

In one week from now we will need to test and adapt if necessary to the new borealis theme. This is the meta #199715. This issue is created to track the work in the ES|QL editor.
@stratoula stratoula added Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels Nov 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. v8.18.0 enhancement New value added to drive a business result labels Nov 14, 2024
@stratoula stratoula mentioned this issue Dec 11, 2024
Merged
ryankeairns added a commit that referenced this issue Dec 11, 2024
@ryankeairns
more lovable text colors (#203692)
6f5d5cd 
Related to #199715
Closes #200160

## Summary

The Kibana ES|QL + Discover teams reviewed the ES|QL editor text colors
and found them to be dull relative to current theme settings. This PR
makes a slight change to use base colors instead of text colors.

**Note**
Longer term - and this consideration was preexisting - we could explore
adding a text-editor-specific set of tokens for use in Monaco editors.
That said, these theme files are not React based, so this might be a
challenge to handle via EUI tokens once the old javascript based theme
tokens are deprecated.

### Before and after

**Editor in 8.X (Amsterdam theme)**
<img width="420"
src="https://github.com/user-attachments/assets/23726e98-9277-4ef4-ae21-c843fc929aa3"
/>

**Editor on main (Borealis theme)**
<img width="400"
src="https://github.com/user-attachments/assets/2b973b8b-d292-46d2-a5d2-0a787f8c686a"
/>

**Editor after this PR (Borealis theme)**
_Light mode_
<img width="600"
src="https://github.com/user-attachments/assets/d34f2961-44b9-4f79-8690-dc44035f8146"
/>

_Dark mode_
<img width="420"
src="https://github.com/user-attachments/assets/e4ccbfb9-4dc1-4c41-ad95-6cc54a8de575"
/>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@ryankeairns @CAWilson94
more lovable text colors (elastic#203692)
d330768 
Related to elastic#199715
Closes elastic#200160

## Summary

The Kibana ES|QL + Discover teams reviewed the ES|QL editor text colors
and found them to be dull relative to current theme settings. This PR
makes a slight change to use base colors instead of text colors.

**Note**
Longer term - and this consideration was preexisting - we could explore
adding a text-editor-specific set of tokens for use in Monaco editors.
That said, these theme files are not React based, so this might be a
challenge to handle via EUI tokens once the old javascript based theme
tokens are deprecated.

### Before and after

**Editor in 8.X (Amsterdam theme)**
<img width="420"
src="https://github.com/user-attachments/assets/23726e98-9277-4ef4-ae21-c843fc929aa3"
/>

**Editor on main (Borealis theme)**
<img width="400"
src="https://github.com/user-attachments/assets/2b973b8b-d292-46d2-a5d2-0a787f8c686a"
/>

**Editor after this PR (Borealis theme)**
_Light mode_
<img width="600"
src="https://github.com/user-attachments/assets/d34f2961-44b9-4f79-8690-dc44035f8146"
/>

_Dark mode_
<img width="420"
src="https://github.com/user-attachments/assets/e4ccbfb9-4dc1-4c41-ad95-6cc54a8de575"
/>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
@ryankeairns @CAWilson94
more lovable text colors (elastic#203692)
dbe39b8 
Related to elastic#199715
Closes elastic#200160

## Summary

The Kibana ES|QL + Discover teams reviewed the ES|QL editor text colors
and found them to be dull relative to current theme settings. This PR
makes a slight change to use base colors instead of text colors.

**Note**
Longer term - and this consideration was preexisting - we could explore
adding a text-editor-specific set of tokens for use in Monaco editors.
That said, these theme files are not React based, so this might be a
challenge to handle via EUI tokens once the old javascript based theme
tokens are deprecated.

### Before and after

**Editor in 8.X (Amsterdam theme)**
<img width="420"
src="https://github.com/user-attachments/assets/23726e98-9277-4ef4-ae21-c843fc929aa3"
/>

**Editor on main (Borealis theme)**
<img width="400"
src="https://github.com/user-attachments/assets/2b973b8b-d292-46d2-a5d2-0a787f8c686a"
/>

**Editor after this PR (Borealis theme)**
_Light mode_
<img width="600"
src="https://github.com/user-attachments/assets/d34f2961-44b9-4f79-8690-dc44035f8146"
/>

_Dark mode_
<img width="420"
src="https://github.com/user-attachments/assets/e4ccbfb9-4dc1-4c41-ad95-6cc54a8de575"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryankeairns ryankeairns

Labels
enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana v8.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

more lovable text colors ryankeairns/kibana
3 participants
@ryankeairns @elasticmachine @stratoula