Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OneDiscover] Enable columns sorting by draggable column header #195769

Closed
kertal opened this issue Oct 10, 2024 · 1 comment · Fixed by #197832
Closed

[OneDiscover] Enable columns sorting by draggable column header #195769

kertal opened this issue Oct 10, 2024 · 1 comment · Fixed by #197832
Assignees
@jughosta
Labels
Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Oct 10, 2024 •
edited
Loading

📓 Summary

Once draggable column headers are available in Kibana elastic/eui#8015, Discover's UnifiedDatable should make use of this new neat functionality. It allows to sort columns of Discover's data table by drag&drop directly on the header, without the need to got to the Columns popover.

✔️ Acceptance criteria

  • The columns in Discover should be sortable by drag and drop of the tables column headers
  • There should be functional coverage dragand drop table column headers
@kertal kertal added Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Project:OneDiscover Enrich Discover with contextual awareness labels Oct 10, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 10, 2024
@kertal kertal added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Oct 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 10, 2024
@kertal kertal added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Oct 21, 2024
@kertal kertal assigned jughosta and unassigned l-suarez Oct 22, 2024
@jughosta jughosta mentioned this issue Oct 25, 2024
Merged
1 task
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 6, 2024
@jughosta
[Discover][UnifiedDataTable] Enable drag&drop for grid columns (elast…
7e82c6d 
…ic#197832)

- Closes elastic#195769

## Summary

Eui now supports reordering of grid columns by dra&drop
elastic/eui#8015
The PR enables this functionality for UnifiedDataTable.

![Nov-01-2024
10-21-49](https://github.com/user-attachments/assets/bc47507c-7b9e-44c2-88d7-5f48f37924cb)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 436405f)
mgadewoll pushed a commit to mgadewoll/kibana that referenced this issue Nov 7, 2024
@jughosta @mgadewoll
[Discover][UnifiedDataTable] Enable drag&drop for grid columns (elast…
2b9171e 
…ic#197832)

- Closes elastic#195769

## Summary

Eui now supports reordering of grid columns by dra&drop
elastic/eui#8015
The PR enables this functionality for UnifiedDataTable.

![Nov-01-2024
10-21-49](https://github.com/user-attachments/assets/bc47507c-7b9e-44c2-88d7-5f48f37924cb)


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover][UnifiedDataTable] Enable drag&drop for grid columns jughosta/kibana
4 participants
@kertal @jughosta @elasticmachine @l-suarez