Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution][Serverless] Incorrect page titles #181060

Closed
semd opened this issue Apr 17, 2024 · 2 comments
Closed

[SecuritySolution][Serverless] Incorrect page titles #181060

semd opened this issue Apr 17, 2024 · 2 comments
Assignees
@semd
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.14.0

Comments

@semd
Copy link
Contributor

semd commented Apr 17, 2024

Describe the bug:

The page title in the browser is wrong for some pages in Security Solution in serverless, incorrectly showing Osquery title.

Steps to reproduce:

  1. Open Security Solution in serverless and navigate to Investigations page on the left nav
  2. The page title in the browser is updated to Osquery

Expected behavior:
The page title in the browser is updated to Investigations

Screenshots (if relevant):

before

Any additional context:

The same problem happens on other pages such as Assets, Machine Learning and Entity Analytics Management.
@semd semd added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore v8.14.0 labels Apr 17, 2024
@semd semd self-assigned this Apr 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@semd semd mentioned this issue Apr 17, 2024
Merged
semd added a commit that referenced this issue Apr 18, 2024
@semd
[Security Solution][Serverless] Fix browser title updater (#181056)
fbfcb06 
## Summary

issue: #181060

Fixes a bug on the Browser title generation from navigation links

### Issue

External links (Discover, Osquery) were not processed properly and they
were being compared using the Security base path (/app/security) in the
`matchPath`, causing the first external link in the list, Osquery, to be
displayed instead of the correct ones.

### Screenshots

Before:

<img width="961" alt="before"
src="https://github.com/elastic/kibana/assets/17747913/3836d956-3a04-443a-8659-6b038a8f0bf4">


After:

<img width="961" alt="after"
src="https://github.com/elastic/kibana/assets/17747913/dfb39139-7cc5-459a-a5de-bc77576ce542">
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Apr 18, 2024
@semd
[Security Solution][Serverless] Fix browser title updater (elastic#18…
da54c4e 
…1056)

## Summary

issue: elastic#181060

Fixes a bug on the Browser title generation from navigation links

### Issue

External links (Discover, Osquery) were not processed properly and they
were being compared using the Security base path (/app/security) in the
`matchPath`, causing the first external link in the list, Osquery, to be
displayed instead of the correct ones.

### Screenshots

Before:

<img width="961" alt="before"
src="https://github.com/elastic/kibana/assets/17747913/3836d956-3a04-443a-8659-6b038a8f0bf4">

After:

<img width="961" alt="after"
src="https://github.com/elastic/kibana/assets/17747913/dfb39139-7cc5-459a-a5de-bc77576ce542">

(cherry picked from commit fbfcb06)
kibanamachine referenced this issue Apr 18, 2024
@kibanamachine @semd
[8.14] [Security Solution][Serverless] Fix browser title updater (#18…
9590ea6 
…1056) (#181108)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Security Solution][Serverless] Fix browser title updater
(#181056)](#181056)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Massaneda","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-18T06:47:52Z","message":"[Security
Solution][Serverless] Fix browser title updater (#181056)\n\n##
Summary\r\n\r\nissue:
https://github.com/elastic/kibana/issues/181060\r\n\r\nFixes a bug on
the Browser title generation from navigation links\r\n\r\n###
Issue\r\n\r\nExternal links (Discover, Osquery) were not processed
properly and they\r\nwere being compared using the Security base path
(/app/security) in the\r\n`matchPath`, causing the first external link
in the list, Osquery, to be\r\ndisplayed instead of the correct
ones.\r\n\r\n### Screenshots\r\n\r\nBefore:\r\n\r\n<img width=\"961\"
alt=\"before\"\r\nsrc=\"https://github.com/elastic/kibana/assets/17747913/3836d956-3a04-443a-8659-6b038a8f0bf4\">\r\n\r\n\r\nAfter:\r\n\r\n<img
width=\"961\"
alt=\"after\"\r\nsrc=\"https://github.com/elastic/kibana/assets/17747913/dfb39139-7cc5-459a-a5de-bc77576ce542\">","sha":"fbfcb063992b9d5e2b7d41bef889a72d71700a62","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","Team:Threat
Hunting:Explore","v8.14.0","v8.15.0"],"title":"[Security
Solution][Serverless] Fix browser title
updater","number":181056,"url":"https://github.com/elastic/kibana/pull/181056","mergeCommit":{"message":"[Security
Solution][Serverless] Fix browser title updater (#181056)\n\n##
Summary\r\n\r\nissue:
https://github.com/elastic/kibana/issues/181060\r\n\r\nFixes a bug on
the Browser title generation from navigation links\r\n\r\n###
Issue\r\n\r\nExternal links (Discover, Osquery) were not processed
properly and they\r\nwere being compared using the Security base path
(/app/security) in the\r\n`matchPath`, causing the first external link
in the list, Osquery, to be\r\ndisplayed instead of the correct
ones.\r\n\r\n### Screenshots\r\n\r\nBefore:\r\n\r\n<img width=\"961\"
alt=\"before\"\r\nsrc=\"https://github.com/elastic/kibana/assets/17747913/3836d956-3a04-443a-8659-6b038a8f0bf4\">\r\n\r\n\r\nAfter:\r\n\r\n<img
width=\"961\"
alt=\"after\"\r\nsrc=\"https://github.com/elastic/kibana/assets/17747913/dfb39139-7cc5-459a-a5de-bc77576ce542\">","sha":"fbfcb063992b9d5e2b7d41bef889a72d71700a62"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181056","number":181056,"mergeCommit":{"message":"[Security
Solution][Serverless] Fix browser title updater (#181056)\n\n##
Summary\r\n\r\nissue:
https://github.com/elastic/kibana/issues/181060\r\n\r\nFixes a bug on
the Browser title generation from navigation links\r\n\r\n###
Issue\r\n\r\nExternal links (Discover, Osquery) were not processed
properly and they\r\nwere being compared using the Security base path
(/app/security) in the\r\n`matchPath`, causing the first external link
in the list, Osquery, to be\r\ndisplayed instead of the correct
ones.\r\n\r\n### Screenshots\r\n\r\nBefore:\r\n\r\n<img width=\"961\"
alt=\"before\"\r\nsrc=\"https://github.com/elastic/kibana/assets/17747913/3836d956-3a04-443a-8659-6b038a8f0bf4\">\r\n\r\n\r\nAfter:\r\n\r\n<img
width=\"961\"
alt=\"after\"\r\nsrc=\"https://github.com/elastic/kibana/assets/17747913/dfb39139-7cc5-459a-a5de-bc77576ce542\">","sha":"fbfcb063992b9d5e2b7d41bef889a72d71700a62"}}]}]
BACKPORT-->

Co-authored-by: Sergi Massaneda <[email protected]>
@semd semd closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@semd semd

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.14.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elasticmachine @semd