Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Graph] Remove kui framework classes #166583

Closed
stratoula opened this issue Sep 18, 2023 · 3 comments · Fixed by #166588
Closed

[Graph] Remove kui framework classes #166583

stratoula opened this issue Sep 18, 2023 · 3 comments · Fixed by #166588
Assignees
@dej611
Labels
Feature:Graph Graph application feature impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@stratoula
Copy link
Contributor

Describe the feature:

Part of #46410

Remove the kui classnames on the buttons. Check if it is needed to add a custom classname or use EUIButtons instead.

https://github.com/elastic/kibana/blob/main/x-pack/plugins/graph/public/components/control_panel/selection_tool_bar.tsx
@stratoula stratoula added Feature:Graph Graph application feature technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Sep 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-graph (Feature:Graph)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula
Copy link
Contributor Author

@dej611 can you add it to your list. Is the last occurrence in graph.

@stratoula stratoula mentioned this issue Sep 18, 2023
Closed
@dej611 dej611 self-assigned this Sep 18, 2023
@dej611 dej611 mentioned this issue Sep 18, 2023
Merged
dej611 added a commit that referenced this issue Sep 18, 2023
@dej611
[Graph] Replace last KUI buttons with EUI ones (#166588)
1b23ebe 
## Summary

Fixes #166583 

<img width="282" alt="Screenshot 2023-09-18 at 10 11 54"
src="https://github.com/elastic/kibana/assets/924948/14c1befa-cc76-4228-bd4c-eff62337448e">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dej611 dej611

Labels
Feature:Graph Graph application feature impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Graph] Replace last KUI buttons with EUI ones dej611/kibana
3 participants
@dej611 @elasticmachine @stratoula