Address review feedback for redesigned user profile page

[legrego]

Feedback to address (#127624 (review)):

• ✔️ Fix left/right padding of the Profile page template Redesigned user profile page #127624 (review)

  • Resolved via Changing left and right padding on User Profiles screen #134944 (@kc13greiner)

• ✔️ Simplify form label markup (or confirm that proposed simplification doesn't work): Redesigned user profile page #127624 (comment) + Introduce user profiles #132522 (comment)

  • Resolved via Removing Flex styled elements #135317 (@kc13greiner)

• ✔️ Elastic Cloud managed users shouldn't be able to see avatar editor (we need to collaborate with @MichaelMarcialis on this one)

  • We shouldn't display avatar and display name editors for the Elastic Cloud managed users as they cannot edit these details yet (see more info on this in Prevent cloud users from updating their user profile #129238). This means that we can only display a header of the Profile page, that might or might not be what we want.
  • We probably need to adjust references to the profile page in the Elastic Cloud context (we use Profile, User settings and Preferences words)
    
    
    * Support for viewing another user's avatar Support for viewing another user's avatar #132636

[elasticmachine]

Pinging @elastic/kibana-security (Team:Security)

[legrego]

@azasypkin if you want, feel free to split this out into separate issues -- it looks like there is some low-hanging fruit that either @jeramysoucy or @kc13greiner could pick up if you wanted to divide and conquer this. Up to you!

[azasypkin]

@azasypkin if you want, feel free to split this out into separate issues -- it looks like there is some low-hanging fruit that either @jeramysoucy or @kc13greiner could pick up if you wanted to divide and conquer this. Up to you!

It's a great idea! I'm going to outline actionable items and then we can deal with them together with @jeramysoucy and/or @kc13greiner.

[kc13greiner]

Fix left/right padding of the Profile page template #127624 (review)

I'll start on this!

[kc13greiner]

Im going to start on this now: #127624 (review)

[kc13greiner]

Elastic Cloud managed users shouldn't be able to see avatar editor

Starting on this

[legrego]

I'm going to remove Support for viewing another user's avatar https://github.com/elastic/kibana/issues/132636 from this meta issue since it's not directly related to the review feedback we received from the initial User Profile redesign. It's still important, I just want to decouple the work.

[jeramysoucy]

Sounds great to me! Let me know what I can do to help.

…

On Thu, Jun 9, 2022 at 7:14 PM Aleh Zasypkin ***@***.***> wrote: @azasypkin <https://github.com/azasypkin> if you want, feel free to split this out into separate issues -- it looks like there is some low-hanging fruit that either @jeramysoucy <https://github.com/jeramysoucy> or @kc13greiner <https://github.com/kc13greiner> could pick up if you wanted to divide and conquer this. Up to you! It's a great idea! I'm going to outline actionable items and then we can deal with them together with @jeramysoucy <https://github.com/jeramysoucy> and/or @kc13greiner <https://github.com/kc13greiner>. — Reply to this email directly, view it on GitHub <#132645 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYY7Z7A3DHRWEBSVRG3TYKTVOIQ6BANCNFSM5WQEMW6Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>