Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Bug: Throughput title with per second is missing a word-space. #108171

Closed
formgeist opened this issue Aug 11, 2021 · 8 comments · Fixed by #107895
Closed

[APM] Bug: Throughput title with per second is missing a word-space. #108171

formgeist opened this issue Aug 11, 2021 · 8 comments · Fixed by #107895
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.15.0

Comments

@formgeist
Copy link
Contributor

Kibana version: master

Summary

We're missing a word break between the Through and "per second" in the panel title.

CleanShot 2021-08-11 at 12 31 46@2x

@formgeist formgeist added bug Fixes for quality problems that affect the customer experience Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.15.0 labels Aug 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist
Copy link
Contributor Author

Additionally, perhaps we can change the tooltip copy of both tooltips to the following;

CleanShot 2021-08-11 at 12 35 29@2x

Throughput is measured in transactions per second (tps)

CleanShot 2021-08-11 at 12 35 50@2x

Throughput is measured in transactions per minute (tpm)

Simply putting the abbreviation in the parenthesis which is typically what I imagine you'd do to reference it. cc @bmorelli25

@sorenlouv
Copy link
Member

Good catch. The initial issue was fixed in #108171

@formgeist
Copy link
Contributor Author

Good catch. The initial issue was fixed in #108171

Not sure what you mean? The issue you're referring to is this one. And why close this?

@sorenlouv
Copy link
Member

Sorry, copy/pasting is hard🤦
I meant to link to this PR 18af095 (#107895)

@formgeist
Copy link
Contributor Author

Ah appreciate it 👍 Did you also change the tooltip content? I can open another issue for this.

@sorenlouv
Copy link
Member

No, I only saw your message with the tooltip after merging the PR. Yes, please open an issue!

@formgeist
Copy link
Contributor Author

@sqren OK, I've opened #108328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.15.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants