[ML] MOAR NP migration.

x-pack/legacy/plugins/transform/public/__mocks__/shared_imports.ts

@@ -4,6 +4,8 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
+jest.mock('ui/new_platform');
+
 export function XJsonMode() {}
 export function setDependencyCache() {}
 export const useRequest = () => ({

x-pack/legacy/plugins/transform/public/app/app.tsx

@@ -5,8 +5,9 @@
  */
 
 import React, { useContext, FC } from 'react';
+import { unmountComponentAtNode } from 'react-dom';
 import { render } from 'react-dom';
-import { Redirect, Route, Switch } from 'react-router-dom';
+import { HashRouter, Redirect, Route, Switch } from 'react-router-dom';
 
 import { FormattedMessage } from '@kbn/i18n/react';
 
@@ -22,8 +23,7 @@ import { TransformManagementSection } from './sections/transform_management';
 
 export const App: FC = () => {
   const { apiError } = useContext(AuthorizationContext);
-
-  if (apiError) {
+  if (apiError !== null) {
     return (
       <SectionError
         title={
@@ -39,33 +39,39 @@ export const App: FC = () => {
 
   return (
     <div data-test-subj="transformApp">
-      <Switch>
-        <Route
-          path={`${CLIENT_BASE_PATH}/${SECTION_SLUG.CLONE_TRANSFORM}/:transformId`}
-          component={CloneTransformSection}
-        />
-        <Route
-          path={`${CLIENT_BASE_PATH}/${SECTION_SLUG.CREATE_TRANSFORM}/:savedObjectId`}
-          component={CreateTransformSection}
-        />
-        <Route
-          exact
-          path={`${CLIENT_BASE_PATH}/${SECTION_SLUG.HOME}`}
-          component={TransformManagementSection}
-        />
-        <Redirect from={`${CLIENT_BASE_PATH}`} to={`${CLIENT_BASE_PATH}/${SECTION_SLUG.HOME}`} />
-      </Switch>
+      <HashRouter>
+        <Switch>
+          <Route
+            path={`${CLIENT_BASE_PATH}${SECTION_SLUG.CLONE_TRANSFORM}/:transformId`}
+            component={CloneTransformSection}
+          />
+          <Route
+            path={`${CLIENT_BASE_PATH}${SECTION_SLUG.CREATE_TRANSFORM}/:savedObjectId`}
+            component={CreateTransformSection}
+          />
+          <Route
+            exact
+            path={`${CLIENT_BASE_PATH}${SECTION_SLUG.HOME}`}
+            component={TransformManagementSection}
+          />
+          <Redirect from={`${CLIENT_BASE_PATH}`} to={`${CLIENT_BASE_PATH}${SECTION_SLUG.HOME}`} />
+        </Switch>
+      </HashRouter>
     </div>
   );
 };
 
-export const renderReact = (elem: Element, appDependencies: AppDependencies) => {
+export const renderApp = (element: HTMLElement, appDependencies: AppDependencies) => {
   const Providers = getAppProviders(appDependencies);
 
   render(
     <Providers>
       <App />
     </Providers>,
-    elem
+    element
   );
+
+  return () => {
+    unmountComponentAtNode(element);
+  };
 };

x-pack/legacy/plugins/transform/public/app/common/navigation.tsx

@@ -29,9 +29,9 @@ export function getDiscoverUrl(indexPatternId: string, baseUrl: string): string
 }
 
 export const RedirectToTransformManagement: FC = () => (
-  <Redirect from={`${CLIENT_BASE_PATH}`} to={`${CLIENT_BASE_PATH}/${SECTION_SLUG.HOME}`} />
+  <Redirect from={`${CLIENT_BASE_PATH}`} to={`${CLIENT_BASE_PATH}${SECTION_SLUG.HOME}`} />
 );
 
 export const RedirectToCreateTransform: FC<{ savedObjectId: string }> = ({ savedObjectId }) => (
-  <Redirect to={`${CLIENT_BASE_PATH}/${SECTION_SLUG.CREATE_TRANSFORM}/${savedObjectId}`} />
+  <Redirect to={`${CLIENT_BASE_PATH}${SECTION_SLUG.CREATE_TRANSFORM}/${savedObjectId}`} />
 );

x-pack/legacy/plugins/transform/public/app/components/section_error.tsx

@@ -4,18 +4,12 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { EuiCallOut, EuiSpacer } from '@elastic/eui';
-import React, { Fragment } from 'react';
+import { EuiCallOut } from '@elastic/eui';
+import React from 'react';
 
 interface Props {
   title: React.ReactNode;
-  error: {
-    data: {
-      error: string;
-      cause?: string[];
-      message?: string;
-    };
-  };
+  error: Error | null;
   actions?: JSX.Element;
 }
 
@@ -25,25 +19,12 @@ export const SectionError: React.FunctionComponent<Props> = ({
   actions,
   ...rest
 }) => {
-  const {
-    error: errorString,
-    cause, // wrapEsError() on the server adds a "cause" array
-    message,
-  } = error.data;
+  const errorMessage =
+    error?.message !== undefined ? error.message : JSON.stringify(error, null, 2);
 
   return (
     <EuiCallOut title={title} color="danger" iconType="alert" {...rest}>
-      {cause ? message || errorString : <p>{message || errorString}</p>}
-      {cause && (
-        <Fragment>
-          <EuiSpacer size="s" />
-          <ul>
-            {cause.map((causeMsg, i) => (
-              <li key={i}>{causeMsg}</li>
-            ))}
-          </ul>
-        </Fragment>
-      )}
+      <pre>{errorMessage}</pre>
       {actions ? actions : null}
     </EuiCallOut>
   );

x-pack/legacy/plugins/transform/public/app/components/toast_notification_text.test.tsx

@@ -14,7 +14,6 @@ import { getAppProviders } from '../app_dependencies';
 import { ToastNotificationText } from './toast_notification_text';
 
 jest.mock('../../shared_imports');
-jest.mock('ui/new_platform');
 
 describe('ToastNotificationText', () => {
   test('should render the text as plain text', () => {

x-pack/legacy/plugins/transform/public/app/constants/index.ts

@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-export const CLIENT_BASE_PATH = '/management/elasticsearch/transform';
+export const CLIENT_BASE_PATH = '/management/elasticsearch/transform/';
 
 export enum SECTION_SLUG {
   HOME = 'transform_management',

x-pack/legacy/plugins/transform/public/app/lib/authorization/components/authorization_provider.tsx

@@ -8,17 +8,9 @@ import React, { createContext } from 'react';
 import { useRequest } from '../../../services/http/use_request';
 import { hasPrivilegeFactory, Capabilities, Privileges } from './common';
 
-interface ApiError {
-  data: {
-    error: string;
-    cause?: string[];
-    message?: string;
-  };
-}
-
 interface Authorization {
   isLoading: boolean;
-  apiError: ApiError | null;
+  apiError: Error | null;
   privileges: Privileges;
   capabilities: Capabilities;
 }
@@ -58,7 +50,7 @@ export const AuthorizationProvider = ({ privilegesEndpoint, children }: Props) =
     isLoading,
     privileges: isLoading ? { ...initialValue.privileges } : privilegesData,
     capabilities: { ...initialCapabalities },
-    apiError: error ? (error as ApiError) : null,
+    apiError: error ? (error as Error) : null,
   };
 
   const hasPrivilege = hasPrivilegeFactory(value.privileges);

x-pack/legacy/plugins/transform/public/app/sections/create_transform/components/source_index_preview/source_index_preview.test.tsx

@@ -12,8 +12,6 @@ import { getPivotQuery } from '../../../../common';
 
 import { SourceIndexPreview } from './source_index_preview';
 
-jest.mock('ui/new_platform');
-
 // workaround to make React.memo() work with enzyme
 jest.mock('react', () => {
   const r = jest.requireActual('react');

x-pack/legacy/plugins/transform/public/app/sections/create_transform/components/step_create/step_create_form.test.tsx

@@ -11,8 +11,6 @@ import { KibanaContext } from '../../../../lib/kibana';
 
 import { StepCreateForm } from './step_create_form';
 
-jest.mock('ui/new_platform');
-
 // workaround to make React.memo() work with enzyme
 jest.mock('react', () => {
   const r = jest.requireActual('react');

x-pack/legacy/plugins/transform/public/app/sections/create_transform/components/step_define/pivot_preview.test.tsx

@@ -19,8 +19,6 @@ import {
 
 import { PivotPreview } from './pivot_preview';
 
-jest.mock('ui/new_platform');
-
 // workaround to make React.memo() work with enzyme
 jest.mock('react', () => {
   const r = jest.requireActual('react');

x-pack/legacy/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_form.test.tsx

@@ -17,8 +17,6 @@ import {
 } from '../../../../common';
 import { StepDefineForm, getAggNameConflictToastMessages } from './step_define_form';
 
-jest.mock('ui/new_platform');
-
 // workaround to make React.memo() work with enzyme
 jest.mock('react', () => {
   const r = jest.requireActual('react');

x-pack/legacy/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_summary.test.tsx

@@ -18,8 +18,6 @@ import {
 import { StepDefineExposedState } from './step_define_form';
 import { StepDefineSummary } from './step_define_summary';
 
-jest.mock('ui/new_platform');
-
 // workaround to make React.memo() work with enzyme
 jest.mock('react', () => {
   const r = jest.requireActual('react');

x-pack/legacy/plugins/transform/public/app/sections/transform_management/components/create_transform_button/create_transform_button.test.tsx

@@ -9,8 +9,6 @@ import React from 'react';
 
 import { CreateTransformButton } from './create_transform_button';
 
-jest.mock('ui/new_platform');
-
 jest.mock('../../../../../shared_imports');
 
 describe('Transform: Transform List <CreateTransformButton />', () => {

x-pack/legacy/plugins/transform/public/app/sections/transform_management/components/transform_list/action_clone.tsx

@@ -30,7 +30,7 @@ export const CloneAction: FC<CloneActionProps> = ({ itemId }) => {
   });
 
   function clickHandler() {
-    history.push(`${CLIENT_BASE_PATH}/${SECTION_SLUG.CLONE_TRANSFORM}/${itemId}`);
+    history.push(`${CLIENT_BASE_PATH}${SECTION_SLUG.CLONE_TRANSFORM}/${itemId}`);
   }
 
   const cloneButton = (

x-pack/legacy/plugins/transform/public/app/sections/transform_management/components/transform_list/action_delete.test.tsx

@@ -16,7 +16,6 @@ import { DeleteAction } from './action_delete';
 import transformListRow from '../../../../common/__mocks__/transform_list_row.json';
 
 jest.mock('ui/new_platform');
-
 jest.mock('../../../../../shared_imports');
 
 describe('Transform: Transform List Actions <DeleteAction />', () => {

x-pack/legacy/plugins/transform/public/app/sections/transform_management/components/transform_list/action_start.test.tsx

@@ -16,7 +16,6 @@ import { StartAction } from './action_start';
 import transformListRow from '../../../../common/__mocks__/transform_list_row.json';
 
 jest.mock('ui/new_platform');
-
 jest.mock('../../../../../shared_imports');
 
 describe('Transform: Transform List Actions <StartAction />', () => {

x-pack/legacy/plugins/transform/public/app/sections/transform_management/components/transform_list/action_stop.test.tsx

@@ -16,7 +16,6 @@ import { StopAction } from './action_stop';
 import transformListRow from '../../../../common/__mocks__/transform_list_row.json';
 
 jest.mock('ui/new_platform');
-
 jest.mock('../../../../../shared_imports');
 
 describe('Transform: Transform List Actions <StopAction />', () => {

x-pack/legacy/plugins/transform/public/app/sections/transform_management/components/transform_list/actions.test.tsx

@@ -6,8 +6,6 @@
 
 import { getActions } from './actions';
 
-jest.mock('ui/new_platform');
-
 jest.mock('../../../../../shared_imports');
 
 describe('Transform: Transform List Actions', () => {

x-pack/legacy/plugins/transform/public/app/sections/transform_management/components/transform_list/columns.test.tsx

@@ -6,8 +6,6 @@
 
 import { getColumns } from './columns';
 
-jest.mock('ui/new_platform');
-
 jest.mock('../../../../../shared_imports');
 
 describe('Transform: Job List Columns', () => {

x-pack/legacy/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.test.tsx

@@ -7,11 +7,8 @@
 import { shallow } from 'enzyme';
 import React from 'react';
 
-import './transform_list.test.mocks';
 import { TransformList } from './transform_list';
 
-jest.mock('ui/new_platform');
-
 jest.mock('../../../../../shared_imports');
 
 describe('Transform: Transform List <TransformList />', () => {

x-pack/legacy/plugins/transform/public/app/sections/transform_management/transform_management_section.test.tsx

@@ -9,7 +9,6 @@ import React from 'react';
 
 import { TransformManagementSection } from './transform_management_section';
 
-jest.mock('ui/new_platform');
 jest.mock('../../../shared_imports');
 
 describe('Transform: <TransformManagementSection />', () => {

x-pack/legacy/plugins/transform/public/app/services/http/use_request.ts

@@ -4,19 +4,13 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import {
-  SendRequestConfig,
-  SendRequestResponse,
-  UseRequestConfig,
-  sendRequest as _sendRequest,
-  useRequest as _useRequest,
-} from '../../../shared_imports';
-import { httpService } from './index';
+import { UseRequestConfig, useRequest as _useRequest } from '../../../shared_imports';
 
-export const sendRequest = (config: SendRequestConfig): Promise<Partial<SendRequestResponse>> => {
-  return _sendRequest(httpService.httpClient, config);
-};
+import { useAppDependencies } from '../../app_dependencies';
 
 export const useRequest = (config: UseRequestConfig) => {
-  return _useRequest(httpService.httpClient, config);
+  const {
+    core: { http },
+  } = useAppDependencies();
+  return _useRequest(http, config);
 };