Code review

src/plugins/data/common/query/filter_manager/compare_filters.test.ts

@@ -228,5 +228,21 @@ describe('filter manager utilities', () => {
 
       expect(compareFilters([f1], [f2], COMPARE_ALL_OPTIONS)).toBeFalsy();
     });
+
+    test('should compare index with index true', () => {
+      const f1 = {
+        $state: { store: FilterStateStore.GLOBAL_STATE },
+        ...buildQueryFilter({ _type: { match: { query: 'apache', type: 'phrase' } } }, 'index', ''),
+      };
+      const f2 = {
+        $state: { store: FilterStateStore.GLOBAL_STATE },
+        ...buildQueryFilter({ _type: { match: { query: 'apache', type: 'phrase' } } }, 'index', ''),
+      };
+
+      f2.meta.index = 'wassup';
+      f2.meta.index = 'dog';
+
+      expect(compareFilters([f1], [f2], { index: true })).toBeFalsy();
+    });
   });
 });

src/plugins/data/public/ui/filter_bar/filter_editor/index.tsx

@@ -202,7 +202,7 @@ class FilterEditorUI extends Component<Props, State> {
       )
     ) {
       /**
-       * Don't render the index pattern index pattern selector if thre's just one \ zero index patterns
+       * Don't render the index pattern selector if there's just one \ zero index patterns
        * and if the index pattern the filter was LOADED with is in the indexPatterns list.
        **/