Skip to content

Commit

Permalink
Merge branch '8.x' into backport/8.x/pr-205833
Browse files Browse the repository at this point in the history
  • Loading branch information
davismcphee authored Jan 9, 2025
2 parents 5c08ade + c472299 commit f6ffbd5
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 23 deletions.
2 changes: 1 addition & 1 deletion docs/spaces/index.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ The `kibana_admin` role or equivalent is required to manage **Spaces**.
=== Create a space

[[spaces-control-feature-visibility]]
You can have up to 100 spaces.
You can have up to 1,000 spaces by default. The maximum number of spaces can be configured by the `xpack.spaces.maxSpaces` setting (refer to <<spaces-settings-kb, Spaces settings in {kib}>>).

. Select *Create space* and provide a name, description, and URL identifier.
+
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ mockedAppContextService.getSecuritySetup.mockImplementation(() => ({

let mockedLogger: jest.Mocked<Logger>;

describe('Test packages', () => {
// Failing: See https://github.com/elastic/kibana/issues/205871
describe.skip('Test packages', () => {
beforeEach(() => {
mockedLogger = loggerMock.create();
mockedAppContextService.getLogger.mockReturnValue(mockedLogger);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@
*/

import { journey, step, before, after } from '@elastic/synthetics';
import { recordVideo } from '@kbn/observability-synthetics-test-data';
import { byTestId } from '../../helpers/utils';
import { syntheticsAppPageProvider } from '../page_objects/synthetics_app';
import { cleanSettings } from './services/settings';

journey('AlertingDefaults', async ({ page, params }) => {
recordVideo(page);
const syntheticsApp = syntheticsAppPageProvider({ page, kibanaUrl: params.kibanaUrl, params });

before(async () => {
Expand Down Expand Up @@ -39,6 +41,7 @@ journey('AlertingDefaults', async ({ page, params }) => {
await page.fill('input[type="text"]', 'Test slack');
await page.press('input[type="text"]', 'Tab');
});

step(
'Fill text=Webhook URLCreate a Slack Webhook URL(external, opens in a new tab or window) >> input[type="text"]',
async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
*/

import { journey, step, before, after, expect } from '@elastic/synthetics';
import { byTestId } from '../../helpers/utils';
import { cleanTestParams } from './services/add_monitor';
import { syntheticsAppPageProvider } from '../page_objects/synthetics_app';

Expand All @@ -25,16 +24,10 @@ journey(`GlobalParameters`, async ({ page, params }) => {
await syntheticsApp.navigateToSettings(true);
});

step('go to params tab', async () => {
await page.click('text=Global Parameters');
});

step('Click text=Settings', async () => {
await page.click(byTestId('settings-page-link'));
expect(page.url()).toBe('http://localhost:5620/app/synthetics/settings/alerting');
});
step('Click text=Global Parameters', async () => {
await page.click('text=Global Parameters');
step('Add params', async () => {
await page.goto('http://localhost:5620/app/synthetics/settings/params', {
waitUntil: 'networkidle',
});
expect(page.url()).toBe('http://localhost:5620/app/synthetics/settings/params');
await page.click('text=No items found');
await page.click('button:has-text("Create Parameter")');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@
import { journey, step, expect, before } from '@elastic/synthetics';
import { SYNTHETICS_API_URLS } from '@kbn/synthetics-plugin/common/constants';
import { recordVideo } from '@kbn/observability-synthetics-test-data';
import { syntheticsAppPageProvider } from '../page_objects/synthetics_app';

journey('ProjectAPIKeys', async ({ page }) => {
journey('ProjectAPIKeys', async ({ page, params }) => {
recordVideo(page);
const syntheticsApp = syntheticsAppPageProvider({ page, kibanaUrl: params.kibanaUrl, params });

let apiKey = '';

Expand All @@ -33,15 +35,7 @@ journey('ProjectAPIKeys', async ({ page }) => {
});

step('Go to http://localhost:5620/login?next=%2Fapp%2Fsynthetics%2Fsettings', async () => {
await page.goto('http://localhost:5620/login?next=%2Fapp%2Fsynthetics%2Fsettings');
await page.click('input[name="username"]');
await page.fill('input[name="username"]', 'elastic');
await page.press('input[name="username"]', 'Tab');
await page.fill('input[name="password"]', 'changeme');
await Promise.all([
page.waitForNavigation({ url: 'http://localhost:5620/app/synthetics/settings/alerting' }),
page.click('button:has-text("Log in")'),
]);
await syntheticsApp.navigateToSettings(true);
});
step('Click text=Project API Keys', async () => {
await page.click('text=Project API Keys');
Expand Down

0 comments on commit f6ffbd5

Please sign in to comment.