Do not render page header for loading domains

elastic · Aug 10, 2021 · da8c4e2 · da8c4e2
1 parent 328c36d
commit da8c4e2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/...e_search/public/applications/app_search/components/crawler/crawler_single_domain.test.tsx b/...e_search/public/applications/app_search/components/crawler/crawler_single_domain.test.tsx
@@ -57,15 +57,17 @@ describe('CrawlerSingleDomain', () => {
     expect(wrapper.prop('pageHeader').pageTitle).toEqual('https://elastic.co');
   });
 
-  it('uses a placeholder for the page title and page chrome if a domain has not been set', () => {
+  it('does not render a page header and uses placeholder chrome while loading', () => {
     setMockValues({
       ...MOCK_VALUES,
+      dataLoading: true,
       domain: null,
     });
 
     const wrapper = shallow(<CrawlerSingleDomain />);
 
-    expect(wrapper.prop('pageHeader').pageTitle).toEqual('Loading...');
+    expect(wrapper.prop('pageChrome')).toContain('...');
+    expect(wrapper.prop('pageHeader')).toBeUndefined();
   });
 
   it('contains a crawler status banner', () => {

diff --git a/...rprise_search/public/applications/app_search/components/crawler/crawler_single_domain.tsx b/...rprise_search/public/applications/app_search/components/crawler/crawler_single_domain.tsx
@@ -32,23 +32,21 @@ export const CrawlerSingleDomain: React.FC = () => {
 
   const { fetchDomainData } = useActions(CrawlerSingleDomainLogic);
 
-  const displayDomainUrl = domain
-    ? domain.url
-    : i18n.translate('xpack.enterpriseSearch.appSearch.crawler.singleDomain.loadingTitle', {
-        defaultMessage: 'Loading...',
-      });
-
   useEffect(() => {
     fetchDomainData(domainId);
   }, []);
 
   return (
     <AppSearchPageTemplate
-      pageChrome={getEngineBreadcrumbs([CRAWLER_TITLE, displayDomainUrl])}
-      pageHeader={{
-        pageTitle: displayDomainUrl,
-        rightSideItems: [<ManageCrawlsPopover />, <CrawlerStatusIndicator />],
-      }}
+      pageChrome={getEngineBreadcrumbs([CRAWLER_TITLE, domain?.url || '...'])}
+      pageHeader={
+        dataLoading
+          ? undefined
+          : {
+              pageTitle: domain!.url,
+              rightSideItems: [<ManageCrawlsPopover />, <CrawlerStatusIndicator />],
+            }
+      }
       isLoading={dataLoading}
     >
       <CrawlerStatusBanner />