Skip to content

Commit

Permalink
Ignore eslint false positives
Browse files Browse the repository at this point in the history
  • Loading branch information
jportner committed Mar 25, 2020
1 parent ad7e4e3 commit c6b8e7a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ export class VegaParser {
*/
_compileVegaLite() {
this.vlspec = this.spec;
const logger = vega.logger(vega.Warn);
// eslint-disable-next-line import/namespace
const logger = vega.logger(vega.Warn); // note: eslint has a false positive here
logger.warn = this._onWarning.bind(this);
this.spec = vegaLite.compile(this.vlspec, logger).spec;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@ export class VegaBaseView {

createViewConfig() {
const config = {
logLevel: vega.Warn,
// eslint-disable-next-line import/namespace
logLevel: vega.Warn, // note: eslint has a false positive here
renderer: this._parser.renderer,
};

Expand Down

0 comments on commit c6b8e7a

Please sign in to comment.