fix(code/frontend): lint errors and type check errors (#29735)

elastic · Feb 1, 2019 · c544348 · c544348
1 parent 02ac170
commit c544348
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 8 deletions.
diff --git a/x-pack/plugins/code/public/components/editor/editor.tsx b/x-pack/plugins/code/public/components/editor/editor.tsx
@@ -28,7 +28,7 @@ export interface EditorActions {
   hoverResult(hover: Hover): void;
 }
 
-interface Props extends EditorActions, RouteComponentProps<MainRouteParams> {
+interface Props {
   file: FetchFileResponse;
   revealPosition?: Position;
   isReferencesOpen: boolean;
@@ -41,13 +41,15 @@ interface Props extends EditorActions, RouteComponentProps<MainRouteParams> {
   showBlame: boolean;
 }
 
-export class EditorComponent extends React.Component<Props> {
+type IProps = Props & EditorActions & RouteComponentProps<MainRouteParams>;
+
+export class EditorComponent extends React.Component<IProps> {
   public blameWidgets: any;
   private container: HTMLElement | undefined;
   private monaco: MonacoHelper | undefined;
   private editor: editorInterfaces.IStandaloneCodeEditor | undefined;
 
-  constructor(props: Props, context: any) {
+  constructor(props: IProps, context: any) {
     super(props, context);
   }
 
@@ -123,7 +125,7 @@ export class EditorComponent extends React.Component<Props> {
 
   public loadBlame(blames: GitBlame[]) {
     this.blameWidgets = blames.map((b, index) => {
-      return new BlameWidget(b, index === 0, this.editor);
+      return new BlameWidget(b, index === 0, this.editor!);
     });
   }
 

diff --git a/x-pack/plugins/code/public/components/main/side_tabs.tsx b/x-pack/plugins/code/public/components/main/side_tabs.tsx
@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { EuiTab, EuiTabbedContent } from '@elastic/eui';
+import { EuiTabbedContent } from '@elastic/eui';
 import {
   euiBorderThin,
   euiColorLightestShade,

diff --git a/x-pack/plugins/code/public/components/theme.ts b/x-pack/plugins/code/public/components/theme.ts
@@ -36,6 +36,5 @@ declare module '@elastic/eui/dist/eui_theme_light.json' {
   const euiColorLightestShade: string;
   const euiBorderThin: string;
   const euiColorDanger: string;
-  const euiColorPrimary: string;
   const euiColorVis0: string;
 }
diff --git a/x-pack/plugins/code/public/monaco/blame/blame_widget.ts b/x-pack/plugins/code/public/monaco/blame/blame_widget.ts
@@ -17,7 +17,11 @@ export class BlameWidget implements Editor.IContentWidget {
   private domNode: HTMLDivElement;
   private containerNode: HTMLDivElement;
 
-  constructor(readonly blame: GitBlame, readonly isFirstLine: boolean, readonly editor: IStand) {
+  constructor(
+    readonly blame: GitBlame,
+    readonly isFirstLine: boolean,
+    readonly editor: Editor.IStandaloneCodeEditor
+  ) {
     this.containerNode = document.createElement('div');
     this.domNode = document.createElement('div');
     this.containerNode.appendChild(this.domNode);

diff --git a/x-pack/plugins/code/public/sagas/editor.ts b/x-pack/plugins/code/public/sagas/editor.ts
@@ -143,7 +143,7 @@ function* handleMainRouteChange(action: Action<Match>) {
   }
   yield put(loadRepo(repoUri));
   if (file) {
-    if ([PathTypes.blob, PathTypes.blame].includes(pathType)) {
+    if ([PathTypes.blob, PathTypes.blame].includes(pathType as PathTypes)) {
       yield call(handleFile, repoUri, file, revision);
       if (position) {
         yield put(revealPosition(position));