removing provider from stubbed_saved_object_index_pattern (#38772)

elastic · Jun 27, 2019 · c0af1d2 · c0af1d2
1 parent 97acab3
commit c0af1d2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 19 deletions.
diff --git a/src/fixtures/stubbed_saved_object_index_pattern.js b/src/fixtures/stubbed_saved_object_index_pattern.js
@@ -17,22 +17,19 @@
  * under the License.
  */
 
-import fixturesLogstashFieldsProvider from './logstash_fields';
+import stubbedLogstashFields from './logstash_fields';
 import { SimpleSavedObject } from '../legacy/ui/public/saved_objects/simple_saved_object';
 
+const mockLogstashFields = stubbedLogstashFields();
 
-export function fixturesStubbedSavedObjectIndexPatternProvider() {
-  const mockLogstashFields = fixturesLogstashFieldsProvider();
-
-  return function (id) {
-    return new SimpleSavedObject(undefined, {
-      id,
-      type: 'index-pattern',
-      attributes: {
-        customFormats: '{}',
-        fields: mockLogstashFields
-      },
-      version: 2
-    });
-  };
+export function stubbedSavedObjectIndexPattern(id) {
+  return new SimpleSavedObject(undefined, {
+    id,
+    type: 'index-pattern',
+    attributes: {
+      customFormats: '{}',
+      fields: mockLogstashFields
+    },
+    version: 2
+  });
 }
diff --git a/src/legacy/ui/public/index_patterns/__tests__/_index_pattern.test.js b/src/legacy/ui/public/index_patterns/__tests__/_index_pattern.test.js
@@ -21,7 +21,7 @@ import _ from 'lodash';
 import { IndexedArray } from '../../indexed_array';
 import { IndexPattern } from '../_index_pattern';
 import mockLogstashFields from '../../../../../fixtures/logstash_fields';
-import { fixturesStubbedSavedObjectIndexPatternProvider } from '../../../../../fixtures/stubbed_saved_object_index_pattern';
+import { stubbedSavedObjectIndexPattern } from '../../../../../fixtures/stubbed_saved_object_index_pattern';
 
 jest.mock('../../errors', () => ({
   SavedObjectNotFound: jest.fn(),
@@ -120,8 +120,6 @@ const config = {
   get: jest.fn(),
 };
 
-const savedObjectsResponse = fixturesStubbedSavedObjectIndexPatternProvider();
-
 // helper function to create index patterns
 function create(id, payload) {
   const indexPattern = new IndexPattern(id, config, savedObjectsClient, patternCache, fieldsFetcher, getIds);
@@ -132,7 +130,7 @@ function create(id, payload) {
 }
 
 function setDocsourcePayload(id, providedPayload) {
-  object = _.defaults(providedPayload || {}, savedObjectsResponse(id));
+  object = _.defaults(providedPayload || {}, stubbedSavedObjectIndexPattern(id));
 }
 
 describe('IndexPattern', () => {