-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Perfomance] Add
is_initial_load
meta (#206645)
closes elastic/observability-dev#4185 ## Summary This PR adds the `is_initial_load` parameter to the meta field to distinguish whether the `onPageReady` trigger occurs during the initial load or a page refresh. Refactoring: - Removed the `target` field. as `context.pageName` now provides the necessary information - Refactor APM instrumentation to simplify it Fixes: - elastic/observability-dev#3464 ###⚠️ Instrumentation The plugins need to call the following function: ``` onPageRefreshStart()``` This method adds a performance marker `start::pageRefresh` to indicate when a page refresh begins. This marker is used along with an end marker `end::pageReady` to determine the total refresh duration. https://github.com/user-attachments/assets/62587d18-b33e-437b-9774-d8e196dbf764 https://github.com/user-attachments/assets/e9c9a761-57bc-4743-9cc7-ea7634696ee3 ### How to test - Checkout the PR - make sure you run `yarn kbn bootstrap` - go to any page that has onPageReady function instrumented (ex services) ### TODO - Once approved, update docs --------- Co-authored-by: Elastic Machine <[email protected]>
- Loading branch information
1 parent
471c413
commit 9a1d70d
Showing
23 changed files
with
405 additions
and
265 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.