[ML] Use real datafeed ID for datafeed preview (#60275)

elastic · Mar 16, 2020 · 8a57896 · 8a57896
1 parent 3a4683c
commit 8a57896
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...ugins/ml/public/application/jobs/jobs_list/components/job_details/datafeed_preview_tab.js b/...ugins/ml/public/application/jobs/jobs_list/components/job_details/datafeed_preview_tab.js
@@ -57,7 +57,8 @@ export class DatafeedPreviewPane extends Component {
   }
 
   componentDidMount() {
-    const canPreviewDatafeed = checkPermission('canPreviewDatafeed');
+    const canPreviewDatafeed =
+      checkPermission('canPreviewDatafeed') && this.props.job.datafeed_config !== undefined;
     this.setState({ canPreviewDatafeed });
 
     updateDatafeedPreview(this.props.job, canPreviewDatafeed)
@@ -87,7 +88,7 @@ function updateDatafeedPreview(job, canPreviewDatafeed) {
   return new Promise((resolve, reject) => {
     if (canPreviewDatafeed) {
       mlJobService
-        .getDatafeedPreview(job.job_id)
+        .getDatafeedPreview(job.datafeed_config.datafeed_id)
         .then(resp => {
           if (Array.isArray(resp)) {
             resolve(JSON.stringify(resp.slice(0, ML_DATA_PREVIEW_COUNT), null, 2));

diff --git a/x-pack/plugins/ml/public/application/services/job_service.js b/x-pack/plugins/ml/public/application/services/job_service.js
@@ -747,8 +747,7 @@ class JobService {
     return datafeedId;
   }
 
-  getDatafeedPreview(jobId) {
-    const datafeedId = this.getDatafeedId(jobId);
+  getDatafeedPreview(datafeedId) {
     return ml.datafeedPreview({ datafeedId });
   }