Use named parameters

elastic · Apr 22, 2020 · 7c33751 · 7c33751
1 parent 2444eb4
commit 7c33751
Showing 1 changed file with 39 additions and 34 deletions.
diff --git a/src/optimize/bundles_route/bundles_route.js b/src/optimize/bundles_route/bundles_route.js
@@ -72,51 +72,56 @@ export function createBundlesRoute({
   }
 
   return [
-    buildRouteForBundles(
-      `${basePublicPath}/bundles/kbn-ui-shared-deps/`,
-      '/bundles/kbn-ui-shared-deps/',
-      UiSharedDeps.distDir,
-      fileHashCache
-    ),
+    buildRouteForBundles({
+      publicPath: `${basePublicPath}/bundles/kbn-ui-shared-deps/`,
+      routePath: '/bundles/kbn-ui-shared-deps/',
+      bundlesPath: UiSharedDeps.distDir,
+      fileHashCache,
+    }),
     ...npUiPluginPublicDirs.map(({ id, path }) =>
-      buildRouteForBundles(
-        `${basePublicPath}/bundles/plugin/${id}/`,
-        `/bundles/plugin/${id}/`,
-        path,
+      buildRouteForBundles({
+        publicPath: `${basePublicPath}/bundles/plugin/${id}/`,
+        routePath: `/bundles/plugin/${id}/`,
+        bundlesPath: path,
         fileHashCache,
-        false
-      )
+        replacePublicPath: false,
+      })
     ),
-    buildRouteForBundles(
-      `${basePublicPath}/bundles/core/`,
-      `/bundles/core/`,
-      fromRoot(join('src', 'core', 'target', 'public')),
+    buildRouteForBundles({
+      publicPath: `${basePublicPath}/bundles/core/`,
+      routePath: `/bundles/core/`,
+      bundlesPath: fromRoot(join('src', 'core', 'target', 'public')),
       fileHashCache,
-      false
-    ),
-    buildRouteForBundles(
-      `${basePublicPath}/bundles/`,
-      '/bundles/',
-      regularBundlesPath,
-      fileHashCache
-    ),
-    buildRouteForBundles(
-      `${basePublicPath}/built_assets/dlls/`,
-      '/built_assets/dlls/',
-      dllBundlesPath,
-      fileHashCache
-    ),
-    buildRouteForBundles(`${basePublicPath}/`, '/built_assets/css/', builtCssPath, fileHashCache),
+      replacePublicPath: false,
+    }),
+    buildRouteForBundles({
+      publicPath: `${basePublicPath}/bundles/`,
+      routePath: '/bundles/',
+      bundlesPath: regularBundlesPath,
+      fileHashCache,
+    }),
+    buildRouteForBundles({
+      publicPath: `${basePublicPath}/built_assets/dlls/`,
+      routePath: '/built_assets/dlls/',
+      bundlesPath: dllBundlesPath,
+      fileHashCache,
+    }),
+    buildRouteForBundles({
+      publicPath: `${basePublicPath}/`,
+      routePath: '/built_assets/css/',
+      bundlesPath: builtCssPath,
+      fileHashCache,
+    }),
   ];
 }
 
-function buildRouteForBundles(
+function buildRouteForBundles({
   publicPath,
   routePath,
   bundlesPath,
   fileHashCache,
-  replacePublicPath = true
-) {
+  replacePublicPath = true,
+}) {
   return {
     method: 'GET',
     path: `${routePath}{path*}`,