dont allow tag creation if id is invalid (#25133)

elastic · Nov 7, 2018 · 755b92b · 755b92b
1 parent 301dfae
commit 755b92b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/x-pack/plugins/beats_management/public/pages/main/create_tag_fragment.tsx b/x-pack/plugins/beats_management/public/pages/main/create_tag_fragment.tsx
@@ -73,7 +73,9 @@ export class CreateTagFragment extends React.PureComponent<TagPageProps, TagPage
             <EuiButton
               fill
               disabled={
-                this.state.tag.id === '' || this.state.tag.configuration_blocks.length === 0
+                this.state.tag.id.search(/^[a-zA-Z0-9-]+$/) === -1 ||
+                this.state.tag.id === '' ||
+                this.state.tag.configuration_blocks.length === 0
               }
               onClick={this.saveTag}
             >

diff --git a/x-pack/plugins/beats_management/public/pages/tag/index.tsx b/x-pack/plugins/beats_management/public/pages/tag/index.tsx
@@ -85,7 +85,9 @@ export class TagPageComponent extends React.PureComponent<TagPageProps, TagPageS
               <EuiButton
                 fill
                 disabled={
-                  this.state.tag.id === '' || this.getNumExclusiveConfigurationBlocks() > 1 // || this.state.tag.configuration_blocks.length === 0
+                  this.state.tag.id.search(/^[a-zA-Z0-9-]+$/) === -1 ||
+                  this.state.tag.id === '' ||
+                  this.getNumExclusiveConfigurationBlocks() > 1 // || this.state.tag.configuration_blocks.length === 0
                 }
                 onClick={this.saveTag}
               >