Fixing flaky runSoon test (#142652) (#142733)

* Unskipping test * Unskipping test * Adding retries * Cleanup (cherry picked from commit f644fde) Co-authored-by: Ying Mao <[email protected]>
elastic · Oct 5, 2022 · 729da47 · 729da47
1 parent 286d73c
commit 729da47
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/run_soon.ts b/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/run_soon.ts
@@ -18,8 +18,7 @@ export default function createRunSoonTests({ getService }: FtrProviderContext) {
   const es = getService('es');
   const esArchiver = getService('esArchiver');
 
-  // Failing: See https://github.com/elastic/kibana/issues/142564
-  describe.skip('runSoon', () => {
+  describe('runSoon', () => {
     const objectRemover = new ObjectRemover(supertest);
 
     before(async () => {
@@ -36,7 +35,7 @@ export default function createRunSoonTests({ getService }: FtrProviderContext) {
 
     it('should successfully run rule where scheduled task id is different than rule id', async () => {
       await retry.try(async () => {
-        // Sometimes the rule may already be running. Try until it isn't
+        // Sometimes the rule may already be running, which returns a 200. Try until it isn't
         const response = await supertest
           .post(`${getUrlPrefix(``)}/internal/alerting/rule/${LOADED_RULE_ID}/_run_soon`)
           .set('kbn-xsrf', 'foo');
@@ -53,10 +52,13 @@ export default function createRunSoonTests({ getService }: FtrProviderContext) {
       expect(response.status).to.eql(200);
       objectRemover.add('default', response.body.id, 'rule', 'alerting');
 
-      const runSoonResponse = await supertest
-        .post(`${getUrlPrefix(``)}/internal/alerting/rule/${response.body.id}/_run_soon`)
-        .set('kbn-xsrf', 'foo');
-      expect(runSoonResponse.status).to.eql(204);
+      await retry.try(async () => {
+        // Sometimes the rule may already be running, which returns a 200. Try until it isn't
+        const runSoonResponse = await supertest
+          .post(`${getUrlPrefix(``)}/internal/alerting/rule/${response.body.id}/_run_soon`)
+          .set('kbn-xsrf', 'foo');
+        expect(runSoonResponse.status).to.eql(204);
+      });
     });
 
     it('should return message when task does not exist for rule', async () => {