style: Prefer null coalescing over ternary

elastic · Feb 13, 2020 · 7162528 · 7162528
1 parent 56fc3f5
commit 7162528
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/...k/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_bulk_route.ts b/...k/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_bulk_route.ts
@@ -81,8 +81,7 @@ export const createCreateRulesBulkRoute = (
             } = payloadRule;
             const ruleIdOrUuid = ruleId ?? uuid.v4();
             try {
-              const finalIndex =
-                outputIndex != null ? outputIndex : getIndex(spacesClient.getSpaceId, config);
+              const finalIndex = outputIndex ?? getIndex(spacesClient.getSpaceId, config);
               const indexExists = await getIndexExists(clusterClient.callAsCurrentUser, finalIndex);
               if (!indexExists) {
                 return createBulkErrorObject({

diff --git a/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_route.ts b/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_route.ts
@@ -75,8 +75,7 @@ export const createCreateRulesRoute = (
           return headers.response().code(404);
         }
 
-        const finalIndex =
-          outputIndex != null ? outputIndex : getIndex(spacesClient.getSpaceId, config);
+        const finalIndex = outputIndex ?? getIndex(spacesClient.getSpaceId, config);
         const indexExists = await getIndexExists(clusterClient.callAsCurrentUser, finalIndex);
         if (!indexExists) {
           return headers

diff --git a/...k/legacy/plugins/siem/server/lib/detection_engine/routes/rules/update_rules_bulk_route.ts b/...k/legacy/plugins/siem/server/lib/detection_engine/routes/rules/update_rules_bulk_route.ts
@@ -74,8 +74,7 @@ export const createUpdateRulesBulkRoute = (
             references,
             version,
           } = payloadRule;
-          const finalIndex =
-            outputIndex != null ? outputIndex : getIndex(spacesClient.getSpaceId, config);
+          const finalIndex = outputIndex ?? getIndex(spacesClient.getSpaceId, config);
           const idOrRuleIdOrUnknown = id ?? ruleId ?? '(unknown id)';
           try {
             const rule = await updateRules({

diff --git a/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/update_rules_route.ts b/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/update_rules_route.ts
@@ -70,8 +70,7 @@ export const createUpdateRulesRoute = (
           return headers.response().code(404);
         }
 
-        const finalIndex =
-          outputIndex != null ? outputIndex : getIndex(spacesClient.getSpaceId, config);
+        const finalIndex = outputIndex ?? getIndex(spacesClient.getSpaceId, config);
         const rule = await updateRules({
           alertsClient,
           actionsClient,