Skip to content

Commit

Permalink
Move vis_type_table to Kibana Platform
Browse files Browse the repository at this point in the history
  • Loading branch information
kertal committed Apr 10, 2020
1 parent 97d1685 commit 4ec811d
Show file tree
Hide file tree
Showing 46 changed files with 297 additions and 359 deletions.
2 changes: 1 addition & 1 deletion .i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"visDefaultEditor": "src/plugins/vis_default_editor",
"visTypeMarkdown": "src/legacy/core_plugins/vis_type_markdown",
"visTypeMetric": "src/legacy/core_plugins/vis_type_metric",
"visTypeTable": "src/legacy/core_plugins/vis_type_table",
"visTypeTable": "src/plugins/vis_type_table",
"visTypeTagCloud": "src/legacy/core_plugins/vis_type_tagcloud",
"visTypeTimeseries": ["src/legacy/core_plugins/vis_type_timeseries", "src/plugins/vis_type_timeseries"],
"visTypeVega": "src/legacy/core_plugins/vis_type_vega",
Expand Down
44 changes: 0 additions & 44 deletions src/legacy/core_plugins/vis_type_table/index.ts

This file was deleted.

4 changes: 0 additions & 4 deletions src/legacy/core_plugins/vis_type_table/package.json

This file was deleted.

This file was deleted.

34 changes: 0 additions & 34 deletions src/legacy/core_plugins/vis_type_table/public/legacy.ts

This file was deleted.

20 changes: 0 additions & 20 deletions src/legacy/core_plugins/vis_type_table/public/legacy_imports.ts

This file was deleted.

This file was deleted.

98 changes: 0 additions & 98 deletions src/legacy/core_plugins/vis_type_table/public/table_vis_type.ts

This file was deleted.

104 changes: 0 additions & 104 deletions src/legacy/core_plugins/vis_type_table/public/vis_controller.ts

This file was deleted.

6 changes: 3 additions & 3 deletions src/plugins/kibana_legacy/public/angular/angular_config.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ export const configureAppAngularModule = (
) => {
const core = 'core' in newPlatform ? newPlatform.core : newPlatform;
const packageInfo =
'injectedMetadata' in newPlatform
? newPlatform.injectedMetadata.getLegacyMetadata()
: newPlatform.env.packageInfo;
'env' in newPlatform
? newPlatform.env.packageInfo
: newPlatform.injectedMetadata.getLegacyMetadata();

if ('injectedMetadata' in newPlatform) {
forOwn(newPlatform.injectedMetadata.getInjectedVars(), (val, name) => {
Expand Down
11 changes: 11 additions & 0 deletions src/plugins/vis_type_table/kibana.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"id": "visTypeTable",
"version": "kibana",
"server": false,
"ui": true,
"requiredPlugins": [
"expressions",
"visualizations",
"data"
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,23 @@ import moment from 'moment';
import ngMock from 'ng_mock';
import expect from '@kbn/expect';
import sinon from 'sinon';
import { npStart } from '../../legacy_imports';
import { round } from 'lodash';
import { getAngularModule } from '../../get_inner_angular';
import { initTableVisLegacyModule } from '../../table_vis_legacy_module';
import { tabifiedData } from './tabified_data';
import { coreMock } from '../../../../../core/public/mocks';

describe('Table Vis - AggTable Directive', function() {
let $rootScope;
let $compile;
let settings;

const initLocalAngular = () => {
const tableVisModule = getAngularModule('kibana/table_vis', npStart.core);
const tableVisModule = getAngularModule(
'kibana/table_vis',
coreMock.createStart(),
coreMock.createPluginInitializerContext()
);
initTableVisLegacyModule(tableVisModule);
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,21 @@
import $ from 'jquery';
import ngMock from 'ng_mock';
import expect from '@kbn/expect';
import { npStart } from '../../legacy_imports';
import { getAngularModule } from '../../get_inner_angular';
import { initTableVisLegacyModule } from '../../table_vis_legacy_module';
import { tabifiedData } from './tabified_data';
import { coreMock } from '../../../../../core/public/mocks';

describe('Table Vis - AggTableGroup Directive', function() {
let $rootScope;
let $compile;

const initLocalAngular = () => {
const tableVisModule = getAngularModule('kibana/table_vis', npStart.core);
const tableVisModule = getAngularModule(
'kibana/table_vis',
coreMock.createStart(),
coreMock.createPluginInitializerContext()
);
initTableVisLegacyModule(tableVisModule);
};

Expand Down
1 change: 1 addition & 0 deletions src/plugins/vis_type_table/public/agg_table/_index.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
@import './agg_table';
Loading

0 comments on commit 4ec811d

Please sign in to comment.