Similarly move use of context to settings form container

We are only interested in the es docs path string in the settings form component so no need to render for other updates.
elastic · Jul 7, 2020 · 4ade0ad · 4ade0ad
1 parent 366e76e
commit 4ade0ad
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/...rocessors_editor/components/processor_settings_form/processor_settings_form.container.tsx b/...rocessors_editor/components/processor_settings_form/processor_settings_form.container.tsx
@@ -10,6 +10,7 @@ import { useForm, OnFormUpdateArg, FormData } from '../../../../../shared_import
 import { ProcessorInternal } from '../../types';
 
 import { ProcessorSettingsForm as ViewComponent } from './processor_settings_form';
+import { usePipelineProcessorsContext } from '../../context';
 
 export type ProcessorSettingsFromOnSubmitArg = Omit<ProcessorInternal, 'id'>;
 
@@ -32,6 +33,10 @@ export const ProcessorSettingsForm: FunctionComponent<Props> = ({
   onSubmit,
   ...rest
 }) => {
+  const {
+    links: { esDocsBasePath },
+  } = usePipelineProcessorsContext();
+
   const handleSubmit = useCallback(
     async (data: FormData, isValid: boolean) => {
       if (isValid) {
@@ -60,5 +65,7 @@ export const ProcessorSettingsForm: FunctionComponent<Props> = ({
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [onFormUpdate]);
 
-  return <ViewComponent processor={processor} form={form} {...rest} />;
+  return (
+    <ViewComponent {...rest} processor={processor} form={form} esDocsBasePath={esDocsBasePath} />
+  );
 };
diff --git a/...pipeline_processors_editor/components/processor_settings_form/processor_settings_form.tsx b/...pipeline_processors_editor/components/processor_settings_form/processor_settings_form.tsx
@@ -21,7 +21,6 @@ import {
 } from '@elastic/eui';
 
 import { Form, FormDataProvider, FormHook } from '../../../../../shared_imports';
-import { usePipelineProcessorsContext } from '../../context';
 import { ProcessorInternal } from '../../types';
 
 import { DocumentationButton } from './documentation_button';
@@ -35,6 +34,7 @@ export interface Props {
   form: FormHook;
   onClose: () => void;
   onOpen: () => void;
+  esDocsBasePath: string;
 }
 
 const updateButtonLabel = i18n.translate(
@@ -52,11 +52,7 @@ const cancelButtonLabel = i18n.translate(
 );
 
 export const ProcessorSettingsForm: FunctionComponent<Props> = memo(
-  ({ processor, form, isOnFailure, onClose, onOpen }) => {
-    const {
-      links: { esDocsBasePath },
-    } = usePipelineProcessorsContext();
-
+  ({ processor, form, isOnFailure, onClose, onOpen, esDocsBasePath }) => {
     const flyoutTitleContent = isOnFailure ? (
       <FormattedMessage
         id="xpack.ingestPipelines.settingsFormOnFailureFlyout.title"