this

elastic · Apr 7, 2020 · 43c6a10 · 43c6a10
1 parent e11e19f
commit 43c6a10
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/x-pack/plugins/endpoint/public/applications/endpoint/models/policy.ts b/x-pack/plugins/endpoint/public/applications/endpoint/models/policy.ts
@@ -42,6 +42,10 @@ export const generatePolicy = (): PolicyConfig => {
     mac: {
       events: {
         process: true,
+        // TODO, is this right?
+        file: true,
+        // TODO, is this right?
+        network: true,
       },
       malware: {
         mode: ProtectionModes.detect,
@@ -67,6 +71,10 @@ export const generatePolicy = (): PolicyConfig => {
     linux: {
       events: {
         process: true,
+        // TODO, is this right?
+        file: true,
+        // TODO, is this right?
+        network: true,
       },
       logging: {
         stdout: 'debug',

diff --git a/x-pack/plugins/endpoint/public/applications/endpoint/types.ts b/x-pack/plugins/endpoint/public/applications/endpoint/types.ts
@@ -195,7 +195,6 @@ export interface UIPolicyConfig {
   mac: MacPolicyConfig;
   linux: LinuxPolicyConfig;
 }
-export type nerds<t extends keyof UIPolicyConfig> = keyof UIPolicyConfig[t]['events'];
 
 /** OS used in Policy */
 export enum OS {

diff --git a/...gins/endpoint/public/applications/endpoint/view/policy/policy_forms/eventing/checkbox.tsx b/...gins/endpoint/public/applications/endpoint/view/policy/policy_forms/eventing/checkbox.tsx
@@ -10,7 +10,7 @@ import { useDispatch } from 'react-redux';
 import { usePolicyDetailsSelector } from '../../policy_hooks';
 import { policyConfig, windowsEventing } from '../../../../store/policy_details/selectors';
 import { PolicyDetailsAction } from '../../../../store/policy_details';
-import { OS, UIPolicyConfig, nerds } from '../../../../types';
+import { UIPolicyConfig } from '../../../../types';
 import { clone } from '../../../../models/policy_details_config';
 
 export const EventingCheckbox = React.memo(function<T extends keyof UIPolicyConfig>({
@@ -22,7 +22,7 @@ export const EventingCheckbox = React.memo(function<T extends keyof UIPolicyConf
   id: string;
   name: string;
   os: T;
-  protectionField: nerds<T>;
+  protectionField: keyof UIPolicyConfig[T]['events'];
 }) {
   const policyDetailsConfig = usePolicyDetailsSelector(policyConfig);
   const eventing = usePolicyDetailsSelector(windowsEventing);
@@ -31,7 +31,7 @@ export const EventingCheckbox = React.memo(function<T extends keyof UIPolicyConf
   const handleCheckboxChange = useCallback(
     (event: React.ChangeEvent<HTMLInputElement>) => {
       if (policyDetailsConfig) {
-        const newPayload = clone(policyDetailsConfig);
+        const newPayload: UIPolicyConfig = clone(policyDetailsConfig);
         newPayload[os].events[protectionField] = event.target.checked;
 
         dispatch({