Skip to content

Commit

Permalink
Fix merge conflicts
Browse files Browse the repository at this point in the history
  • Loading branch information
Maja Grubic committed Feb 23, 2023
1 parent 67a8706 commit 39ec7a2
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions src/plugins/saved_objects_finder/kibana.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
"id": "savedObjectsFinder",
"server": true,
"browser": true,
"requiredBundles": [
"savedObjects"
]
"requiredBundles": []
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export class SavedObjectFinderUi extends React.Component<
attributes: { name, title },
} = savedObject;
const titleToUse = typeof title === 'string' ? title : '';
const nameToUse = name && typeof name === 'string' ? name : titleToUse;
const nameToUse = name ? name : titleToUse;
return {
...savedObject,
version: savedObject.version,
Expand Down
2 changes: 0 additions & 2 deletions test/functional/services/dashboard/add_panel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ export class DashboardAddPanelService extends FtrService {
for (let i = 0; i < listItems.length; i++) {
const listItem = await listItems[i].findByClassName('euiSelectableListItem__text');
const text = await listItem.getVisibleText();
this.log.debug('**** ' + text + ' ****');
if (text.includes(type)) {
await listItem.click();
await this.toggleFilterPopover();
Expand Down Expand Up @@ -250,7 +249,6 @@ export class DashboardAddPanelService extends FtrService {
await this.toggleFilter(embeddableType);
await this.filterEmbeddableNames(`"${embeddableName.replace('-', ' ')}"`);
await this.testSubjects.click(`savedObjectTitle${embeddableName.split(' ').join('-')}`);
this.log.debug('*****' + 'Clicked' + '******');
await this.testSubjects.exists('addObjectToDashboardSuccess');
await this.closeAddPanel();
return embeddableName;
Expand Down

0 comments on commit 39ec7a2

Please sign in to comment.