Improve app mountpoint, remove innerHTML

elastic · Nov 26, 2019 · 2ff88db · 2ff88db
1 parent 83f1bb4
commit 2ff88db
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/legacy/core_plugins/kibana/public/discover/application.ts b/src/legacy/core_plugins/kibana/public/discover/application.ts
@@ -30,8 +30,9 @@ export async function renderApp(moduleName: string, element: HTMLElement) {
 
 function mountDiscoverApp(moduleName: string, element: HTMLElement) {
   const mountpoint = document.createElement('div');
-  // eslint-disable-next-line
-  mountpoint.innerHTML = `<div ng-view></div>`;
+  const appWrapper = document.createElement('div');
+  appWrapper.setAttribute('ng-view', '');
+  mountpoint.appendChild(appWrapper);
   // bootstrap angular into detached element and attach it later to
   // make angular-within-angular possible
   const $injector = angular.bootstrap(mountpoint, [moduleName]);