-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Configurable heatmap maximum bucket number (#39578)
* Add visualization:heatmap:maxBuckets to settings (default: 50) * Use visualization:heatmap:maxBuckets at heatmap (before it was hardcoded) * Convert heatmap tests from mocha to jest
- Loading branch information
Showing
5 changed files
with
132 additions
and
46 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 108 additions & 0 deletions
108
src/legacy/ui/public/vislib/lib/types/point_series.test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch B.V. licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import stackedSeries from '../../../../../../fixtures/vislib/mock_data/date_histogram/_stacked_series'; | ||
| import { vislibPointSeriesTypes } from './point_series'; | ||
|
|
||
| describe('vislibPointSeriesTypes', () => { | ||
| const heatmapConfig = { | ||
| type: 'heatmap', | ||
| addLegend: true, | ||
| addTooltip: true, | ||
| colorsNumber: 4, | ||
| colorSchema: 'Greens', | ||
| setColorRange: false, | ||
| percentageMode: true, | ||
| invertColors: false, | ||
| colorsRange: [], | ||
| heatmapMaxBuckets: 20 | ||
| }; | ||
|
|
||
| const stackedData = { | ||
| get: prop => { | ||
| return stackedSeries[prop] || null; | ||
| }, | ||
| getLabels: () => [], | ||
| data: stackedSeries, | ||
| }; | ||
|
|
||
| const maxBucketData = { | ||
| get: prop => { | ||
| return maxBucketData[prop] || maxBucketData.data[prop] || null; | ||
| }, | ||
| getLabels: () => [], | ||
| data: { | ||
| hits: 621, | ||
| ordered: { | ||
| date: true, | ||
| interval: 30000, | ||
| max: 1408734982458, | ||
| min: 1408734082458, | ||
| }, | ||
| series: [ | ||
| { label: 's1', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's2', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's3', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's4', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's5', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's6', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's7', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's8', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's9', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's10', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's11', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's12', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's13', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's14', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's15', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's16', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's17', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's18', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's19', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's20', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's21', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's22', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's23', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's24', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's25', values: [{ x: 1408734060000, y: 8 }] }, | ||
| { label: 's26', values: [{ x: 1408734060000, y: 8 }] }, | ||
| ], | ||
| xAxisLabel: 'Date Histogram', | ||
| yAxisLabel: 'series', | ||
| yAxisFormatter: () => 'test', | ||
| }, | ||
| }; | ||
|
|
||
| describe('heatmap()', () => { | ||
| it('should return an error when more than 20 series are provided', () => { | ||
| const parsedConfig = vislibPointSeriesTypes.heatmap(heatmapConfig, maxBucketData); | ||
| expect(parsedConfig.error).toMatchInlineSnapshot( | ||
| `"There are too many series defined (26). The configured maximum is 20."` | ||
| ); | ||
| }); | ||
|
|
||
| it('should return valid config when less than 20 series are provided', () => { | ||
| const parsedConfig = vislibPointSeriesTypes.heatmap(heatmapConfig, stackedData); | ||
| expect(parsedConfig.error).toBeUndefined(); | ||
| expect(parsedConfig.valueAxes[0].show).toBeFalsy(); | ||
| expect(parsedConfig.categoryAxes.length).toBe(2); | ||
| expect(parsedConfig.error).toBeUndefined(); | ||
| }); | ||
|
|
||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters