Fixing duration field formatter showing 0 seconds instead of "few sec…

…onds" (#164659) This PR solves the issue when a user is formatting fields that are "0" to be Human Friendly, then it shows "a few seconds" instead of "0.00 seconds" This PR changes it to say: "0.00 seconds". I have also updated the test-case for it. Video of the issue - tested on 8.11 snapshot: https://github.com/elastic/kibana/assets/108192783/082329bf-6c62-4eb5-b28e-212a848f6f65 Screenshot of the fix: <img width="1361" alt="Skærmbillede 2023-08-24 kl 10 36 15" src="https://github.com/elastic/kibana/assets/108192783/cc9a4490-e8b3-48a6-952e-61e9cd0aff81"> Fixes #101000 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Matthias Wilhelm <[email protected]> Co-authored-by: Davis McPhee <[email protected]>
elastic · Aug 24, 2023 · 2d9b46d · 2d9b46d
1 parent c66f58a
commit 2d9b46d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/plugins/field_formats/common/converters/duration.test.ts b/src/plugins/field_formats/common/converters/duration.test.ts
@@ -15,6 +15,10 @@ describe('Duration Format', () => {
     outputPrecision: undefined,
     showSuffix: undefined,
     fixtures: [
+      {
+        input: 0,
+        output: '0 seconds',
+      },
       {
         input: -60,
         output: 'minus a minute',

diff --git a/src/plugins/field_formats/common/converters/duration.ts b/src/plugins/field_formats/common/converters/duration.ts
@@ -99,6 +99,12 @@ export class DurationFormat extends FieldFormat {
     const human = this.isHuman();
     const humanPrecise = this.isHumanPrecise();
 
+    if (human && val === 0) {
+      return i18n.translate('fieldFormats.duration.zeroSecondsLabel', {
+        defaultMessage: '0 seconds',
+      }); // Handle the case of 0 value for "Human Friendly"
+    }
+
     const prefix =
       val < 0 && human
         ? i18n.translate('fieldFormats.duration.negativeLabel', {