Skip to content

Commit

Permalink
Relocating module @kbn/url-drilldown-plugin
Browse files Browse the repository at this point in the history
  • Loading branch information
Dosant committed Jan 8, 2025
1 parent 2429eb7 commit 1e55cfc
Show file tree
Hide file tree
Showing 25 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,7 @@ x-pack/platform/plugins/private/custom_branding @elastic/appex-sharedux
x-pack/platform/plugins/private/data_usage @elastic/obs-ai-assistant @elastic/security-solution
x-pack/platform/plugins/private/data_visualizer @elastic/ml-ui
x-pack/platform/plugins/private/discover_enhanced @elastic/kibana-data-discovery
x-pack/platform/plugins/private/drilldowns/url_drilldown @elastic/appex-sharedux
x-pack/platform/plugins/private/file_upload @elastic/kibana-presentation @elastic/ml-ui
x-pack/platform/plugins/private/global_search_bar @elastic/appex-sharedux
x-pack/platform/plugins/private/global_search_providers @elastic/appex-sharedux
Expand Down Expand Up @@ -904,7 +905,6 @@ x-pack/platform/plugins/shared/stack_alerts @elastic/response-ops
x-pack/platform/plugins/shared/stack_connectors @elastic/response-ops
x-pack/platform/plugins/shared/task_manager @elastic/response-ops
x-pack/platform/plugins/shared/triggers_actions_ui @elastic/response-ops
x-pack/plugins/drilldowns/url_drilldown @elastic/appex-sharedux
x-pack/solutions/observability/packages/alert_details @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/alerting_test_data @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/get_padded_alert_time_range_util @elastic/obs-ux-management-team
Expand Down
2 changes: 1 addition & 1 deletion docs/developer/plugin-list.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -970,7 +970,7 @@ As a developer you can reuse and extend built-in alerts and actions UI functiona
in their infrastructure.
|{kib-repo}blob/{branch}/x-pack/plugins/drilldowns/url_drilldown/README.md[urlDrilldown]
|{kib-repo}blob/{branch}/x-pack/platform/plugins/private/drilldowns/url_drilldown/README.md[urlDrilldown]
|NOTE: This plugin contains implementation of URL drilldown. For drilldowns infrastructure code refer to ui_actions_enhanced plugin.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -996,7 +996,7 @@
"@kbn/unsaved-changes-prompt": "link:src/platform/packages/shared/kbn-unsaved-changes-prompt",
"@kbn/upgrade-assistant-plugin": "link:x-pack/platform/plugins/private/upgrade_assistant",
"@kbn/uptime-plugin": "link:x-pack/solutions/observability/plugins/uptime",
"@kbn/url-drilldown-plugin": "link:x-pack/plugins/drilldowns/url_drilldown",
"@kbn/url-drilldown-plugin": "link:x-pack/platform/plugins/private/drilldowns/url_drilldown",
"@kbn/url-forwarding-plugin": "link:src/platform/plugins/private/url_forwarding",
"@kbn/usage-collection-plugin": "link:src/platform/plugins/shared/usage_collection",
"@kbn/usage-collection-test-plugin": "link:test/plugin_functional/plugins/usage_collection",
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -2008,8 +2008,8 @@
"@kbn/upgrade-assistant-plugin/*": ["x-pack/platform/plugins/private/upgrade_assistant/*"],
"@kbn/uptime-plugin": ["x-pack/solutions/observability/plugins/uptime"],
"@kbn/uptime-plugin/*": ["x-pack/solutions/observability/plugins/uptime/*"],
"@kbn/url-drilldown-plugin": ["x-pack/plugins/drilldowns/url_drilldown"],
"@kbn/url-drilldown-plugin/*": ["x-pack/plugins/drilldowns/url_drilldown/*"],
"@kbn/url-drilldown-plugin": ["x-pack/platform/plugins/private/drilldowns/url_drilldown"],
"@kbn/url-drilldown-plugin/*": ["x-pack/platform/plugins/private/drilldowns/url_drilldown/*"],
"@kbn/url-forwarding-plugin": ["src/platform/plugins/private/url_forwarding"],
"@kbn/url-forwarding-plugin/*": ["src/platform/plugins/private/url_forwarding/*"],
"@kbn/usage-collection-plugin": ["src/platform/plugins/shared/usage_collection"],
Expand Down
2 changes: 1 addition & 1 deletion x-pack/.i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@
"xpack.ux": [
"solutions/observability/plugins/ux"
],
"xpack.urlDrilldown": "plugins/drilldowns/url_drilldown",
"xpack.urlDrilldown": "platform/plugins/private/drilldowns/url_drilldown",
"xpack.watcher": "platform/plugins/private/watcher"
},
"exclude": [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../../../../tsconfig.base.json",
"extends": "../../../../../../tsconfig.base.json",
"compilerOptions": {
"outDir": "target/types",
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function isUrlDrilldown(action: Action) {

// VALUE_CLICK_TRIGGER is coupled with expressions and Datatable type
// URL drilldown parses event scope from Datatable
// https://github.com/elastic/kibana/blob/7.10/x-pack/plugins/drilldowns/url_drilldown/public/lib/url_drilldown_scope.ts#L140
// https://github.com/elastic/kibana/blob/7.10/x-pack/platform/plugins/private/drilldowns/url_drilldown/public/lib/url_drilldown_scope.ts#L140
// In order to use URL drilldown, maps has to package its data in Datatable compatiable format.
export function toValueClickDataFormat(key: string, value: RawValue) {
return [
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/drilldowns/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ module.exports = {
roots: ['<rootDir>/x-pack/plugins/drilldowns'],
coverageDirectory: '<rootDir>/target/kibana-coverage/jest/x-pack/plugins/drilldowns',
coverageReporters: ['text', 'html'],
collectCoverageFrom: ['<rootDir>/x-pack/plugins/drilldowns/url_drilldown/public/**/*.{ts,tsx}'],
collectCoverageFrom: ['<rootDir>/x-pack/platform/plugins/private/drilldowns/url_drilldown/public/**/*.{ts,tsx}'],
};
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7869,7 +7869,7 @@
version "0.0.0"
uid ""

"@kbn/url-drilldown-plugin@link:x-pack/plugins/drilldowns/url_drilldown":
"@kbn/url-drilldown-plugin@link:x-pack/platform/plugins/private/drilldowns/url_drilldown":
version "0.0.0"
uid ""

Expand Down

0 comments on commit 1e55cfc

Please sign in to comment.