Comments from review :)

elastic · Feb 12, 2020 · 1dc2c04 · 1dc2c04
1 parent 363b340
commit 1dc2c04
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/x-pack/legacy/plugins/siem/public/pages/hosts/details/details_tabs.test.tsx b/x-pack/legacy/plugins/siem/public/pages/hosts/details/details_tabs.test.tsx
@@ -47,6 +47,15 @@ describe('body', () => {
 
   const mockHostDetailsPageFilters = getHostDetailsPageFilters('host-1');
 
+  const filterQuery = JSON.stringify({
+    bool: {
+      must: [],
+      filter: [{ match_all: {} }, { match_phrase: { 'host.name': { query: 'host-1' } } }],
+      should: [],
+      must_not: [],
+    },
+  });
+
   const componentProps: Record<string, Partial<HostDetailsTabsProps>> = {
     events: { pageFilters: mockHostDetailsPageFilters },
     alerts: { pageFilters: mockHostDetailsPageFilters },
@@ -69,7 +78,7 @@ describe('body', () => {
               indexPattern={mockIndexPattern}
               type={type}
               pageFilters={mockHostDetailsPageFilters}
-              filterQuery='{"bool":{"must":[],"filter":[{"match_all":{}},{"match_phrase":{"host.name":{"query":"host-1"}}}],"should":[],"must_not":[]}}'
+              filterQuery={filterQuery}
             />
           </MemoryRouter>
         </TestProviders>
@@ -78,8 +87,7 @@ describe('body', () => {
       // match against everything but the functions to ensure they are there as expected
       expect(wrapper.find(componentName).props()).toMatchObject({
         endDate: 0,
-        filterQuery:
-          '{"bool":{"must":[],"filter":[{"match_all":{}},{"match_phrase":{"host.name":{"query":"host-1"}}}],"should":[],"must_not":[]}}',
+        filterQuery,
         skip: false,
         startDate: 0,
         type: 'details',

diff --git a/x-pack/legacy/plugins/siem/public/pages/hosts/details/helpers.test.ts b/x-pack/legacy/plugins/siem/public/pages/hosts/details/helpers.test.ts
@@ -5,6 +5,7 @@
  */
 
 import { getHostDetailsEventsKqlQueryExpression, getHostDetailsPageFilters } from './helpers';
+import { esFilters } from '../../../../../../../../src/plugins/data/common/es_query';
 
 describe('hosts page helpers', () => {
   describe('getHostDetailsEventsKqlQueryExpression', () => {
@@ -38,7 +39,7 @@ describe('hosts page helpers', () => {
 
   describe('getHostDetailsPageFilters', () => {
     it('correctly constructs pageFilters for the given hostName', () => {
-      expect(getHostDetailsPageFilters('host-1')).toEqual([
+      const expected: esFilters.Filter[] = [
         {
           meta: {
             alias: null,
@@ -60,7 +61,8 @@ describe('hosts page helpers', () => {
             },
           },
         },
-      ]);
+      ];
+      expect(getHostDetailsPageFilters('host-1')).toEqual(expected);
     });
   });
 });